Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udiskie: 1.7.4 -> 1.7.5 #41480

Merged
merged 1 commit into from Jun 5, 2018
Merged

udiskie: 1.7.4 -> 1.7.5 #41480

merged 1 commit into from Jun 5, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 5, 2018 •
edited

Motivation for this change

udiskie breaks for me with the following error when using 1.7.4:

Traceback (most recent call last):
  File "/nix/store/cqa72mqgm5gi0xpqp5r8csdizv3p3ajr-udiskie-1.7.4/lib/python3.6/site-packages/udiskie/cli.py", line 307, in _start_async_tasks
    results = yield self._init()
  File "/nix/store/cqa72mqgm5gi0xpqp5r8csdizv3p3ajr-udiskie-1.7.4/lib/python3.6/site-packages/udiskie/cli.py", line 495, in _init
    tasks.append(Async())
NameError: name 'Async' is not defined

The error has been confirmed by the Debian issue tracker, so it's
obviously not related to NixOS.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=899419 for further
reference.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
udiskie: 1.7.4 -> 1.7.5
8470ce1 
`udiskie` breaks for me with the following error when using 1.7.4:

```
Traceback (most recent call last):
  File "/nix/store/cqa72mqgm5gi0xpqp5r8csdizv3p3ajr-udiskie-1.7.4/lib/python3.6/site-packages/udiskie/cli.py", line 307, in _start_async_tasks
    results = yield self._init()
  File "/nix/store/cqa72mqgm5gi0xpqp5r8csdizv3p3ajr-udiskie-1.7.4/lib/python3.6/site-packages/udiskie/cli.py", line 495, in _init
    tasks.append(Async())
NameError: name 'Async' is not defined
```

The error has been confirmed by the Debian issue tracker, so it's
obviously not related to NixOS.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=899419 for further
reference.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: udiskie

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: udiskie

Partial log (click to expand)

checking for references to /build in /nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5...
Wrapping program /nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/udiskie
Wrapping program /nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/udiskie-info
Wrapping program /nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/udiskie-mount
Wrapping program /nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/udiskie-umount
wrapping `/nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/.udiskie-wrapped'...
wrapping `/nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/.udiskie-info-wrapped'...
wrapping `/nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/.udiskie-mount-wrapped'...
wrapping `/nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5/bin/.udiskie-umount-wrapped'...
/nix/store/kza6cfh5zyipiqad7gf4xa0gqjzsbg2b-udiskie-1.7.5

@xeji xeji merged commit db68f31 into NixOS:master Jun 5, 2018
@Ma27 Ma27 deleted the fix-udiskie branch June 5, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji