Allow passing non-Opal objects to Opal.is_a (#1839)

opal · Jun 5, 2018 · 8cdbc41 · 8cdbc41
1 parent 9e5e9ba
commit 8cdbc41
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/opal/corelib/runtime.js b/opal/corelib/runtime.js
@@ -1177,6 +1177,8 @@
 
   // The Array of ancestors for a given module/class
   Opal.ancestors = function(module) {
+    if (!module) { return []; }
+
     if (module.$$ancestors_cache_version === Opal.const_cache_version) {
       return module.$$ancestors;
     }

diff --git a/spec/opal/core/runtime/is_a_spec.rb b/spec/opal/core/runtime/is_a_spec.rb
@@ -31,5 +31,9 @@
       `!!#{Integer}.$$is_number_class`.should == true
       `!!#{Float}.$$is_number_class`.should == true
     end
+
+    it 'works for non-Opal objects' do
+      `Opal.is_a({}, Opal.Array)`.should == false
+    end
   end
 end