Small improvements to the docker registry module #41478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example:
services.dockerRegistry = {
enable = true;
extraConfig = {
http = {
host = "https://${config.networking.hostName}:5000";
tls = {
certificate = "${registry-tls}/snakeoil.pem";
key = "${registry-tls}/snakeoil.key";
};
};
};
};
peterhoeg
reviewed
Jun 5, 2018
| @@ -119,6 +119,7 @@ in { | |||
|
|
|||
| serviceConfig = { | |||
| User = "docker-registry"; | |||
| AmbientCapabilities = "cap_net_bind_service"; | |||
There was a problem hiding this comment.
This is only needed if cfg.port < 1024 so please add a mkIf for that.
There was a problem hiding this comment.
done that, tnx, nice addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I needed to be able to run the registry on ssl and port 443 without putting some web server in front
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)