Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iasl: integrate upstream patch for acpica/acpica#387 #41481

Merged
merged 1 commit into from Jun 5, 2018
Merged

iasl: integrate upstream patch for acpica/acpica#387 #41481

merged 1 commit into from Jun 5, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Jun 5, 2018 •
edited

Motivation for this change

See:

Probably want to wait until acpica/acpica#389 is merged. ✔️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313
shrinking /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313/bin/iasl
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313/bin
patching script interpreter paths in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313
checking for references to /build in /nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313...
/nix/store/l3v24w46nq83gbdrhkkddmyy6dc2ch7y-iasl-20180313

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313
shrinking /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313/bin/iasl
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313/bin
patching script interpreter paths in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313
checking for references to /build in /nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313...
/nix/store/cq3gcvwxxxbbpxrqlb97hzyji4mv4xhs-iasl-20180313

xeji
xeji suggested changes Jun 5, 2018
View reviewed changes
pkgs/development/compilers/iasl/default.nix Outdated
];

buildFlags = "iasl";

buildInputs = [ bison flex ];

patches = fetchurl {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchpatch instead.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: iasl

Partial log (click to expand)


trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/gffsaq07p6s8rp87f0g40qsfpxr7kpn0-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: iasl

Partial log (click to expand)


trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/d7sl9q1mk8kd5gq3dk6xp6vsbpcn2aig-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 5, 2018

Try this format for patch url, fetchpatch needs the full commit hash:

url = https://github.com/drkjam/netaddr/commit/2ab73f10be7069c9412e853d2d0caf29bd624012.patch;

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: iasl

Partial log (click to expand)


trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/gffsaq07p6s8rp87f0g40qsfpxr7kpn0-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/5almkqnb4d7iihsi3xjksn3ppa58ikjp-iasl-20180313.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: iasl

Partial log (click to expand)


trying https://github.com/acpica/acpica/pull/935ca65f780.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download 935ca65f780.patch from any mirror
builder for '/nix/store/d7sl9q1mk8kd5gq3dk6xp6vsbpcn2aig-935ca65f780.patch.drv' failed with exit code 1
cannot build derivation '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv': 1 dependencies couldn't be built
error: build of '/nix/store/79i4bl08vy7dcnb51ffi2mffnc36hiwm-iasl-20180313.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 5, 2018

failing URL looks the same as before.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313
shrinking /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313/bin/iasl
strip is /nix/store/85wqgd5aj4g57g1fsrnmdbq4mf1kz957-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313/bin
patching script interpreter paths in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313
checking for references to /build in /nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313...
/nix/store/rv01b2wy4rli7b1x7s57zg8mwwkmhvx3-iasl-20180313

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: iasl

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313
shrinking /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313/bin/iasl
strip is /nix/store/ks7k1wdljx2knaayzr528cwbj6v970km-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313/bin
patching script interpreter paths in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313
checking for references to /build in /nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313...
/nix/store/aqfqdd10rxvkjgqbcwx2pwqgzfx6f4xi-iasl-20180313

@xeji xeji merged commit 8a999d1 into NixOS:gcc8 Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @xeji