zoom-us: update && added new field to meta attributes
#41215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handy for maintainers, but can be used in future by proactive automated package update detectors. While here, replaced http:// -> https:// in doc/meta.nix
GrahamcOfBorg
added
6.topic: stdenv
It is used more then in one place, so probably deserves a separate PR.
|
I'd prefer |
|
@tadfisher you mean, rename |
|
I'm sorry for bikeshedding this, but could we split the releaseNews idea into a separate PR? I think it deserves more visibility than what it'll get in a specific package PR, and it'll hold up zoom needlessly. |
|
Agreed, let's drop 5ae8361 and open that as a separate PR. |
|
Superseeded by #42742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
zoom-us upgrade.
Second commit adds
releaseNewsmeta-attribute. If it is controversial or unwanted, that commit may be dropped. Personally, I often find it hard to find the release news link in google, so I propose to document found one in nixpkgs.And made meta.nix doc more secure (!) by making all links to GNU hello https://
And fixed homepage link for GNU hello - previously it was a link to manual, not homepage.
EDIT: reverted this change, there are plenty of references, need to change them all, but this is out of scope for this PR.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)