Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkd: dontStrip as a workaround for binutils strip problem #41226

Merged
merged 1 commit into from May 30, 2018
Merged

gtkd: dontStrip as a workaround for binutils strip problem #41226

merged 1 commit into from May 30, 2018

Conversation

ThomasMader
Copy link
Contributor

Motivation for this change

This fixes #41188 and is needed because binutils won't be fixed till 2.31 is released. See #40397.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ThomasMader ThomasMader mentioned this pull request May 29, 2018
Closed
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gtkd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtkd

Partial log (click to expand)

peas/PluginManagerView.d
peasc/peas.d
peasc/peastypes.d
install -m 644 peasd-3.pc /nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5/share/pkgconfig
install -m 644 libpeasd-3.a /nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5/lib/
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5
patching script interpreter paths in /nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5
checking for references to /build in /nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5...

@xeji
Copy link
Contributor

xeji commented May 29, 2018

let's check the darwin build and tilix
@GrahamcOfBorg build gtkd tilix

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gtkd, tilix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gtkd, tilix

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtkd, tilix

Partial log (click to expand)

Wrapping program /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1/bin/tilix
shrinking RPATHs of ELF executables and libraries in /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1
shrinking /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1/bin/.tilix-wrapped
gzipping man pages under /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1/share/man/
strip is /nix/store/92d2ifxcni4n3zx9s8wnkcjlvnx5ajlc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1/bin
patching script interpreter paths in /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1
checking for references to /build in /nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1...
/nix/store/c3cmgysgd34vmd1wsk3wvbl05rm4wrvr-gtkd-3.6.5
/nix/store/3q29mcfbkv9iy0gi2w4nhzmsaf6bvjcx-tilix-1.7.1

@xeji
Copy link
Contributor

xeji commented May 29, 2018

gtkd's meta.platforms includes darwin but its dependency libgda is unsupported.

xeji
xeji reviewed May 29, 2018
View reviewed changes
pkgs/development/libraries/gtkd/default.nix
@@ -84,6 +84,9 @@ stdenv.mkDerivation rec {

installFlags = "prefix=$(out)";

# Workaround for https://github.com/NixOS/nixpkgs/issues/40397
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here that this should be removed after upgrading binutils to 2.31?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gtkd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit 1d5c454 into NixOS:master May 30, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: gtkd

Partial log (click to expand)

test [rustdoc] rustdoc/issue-45584.rs ... ok
test [rustdoc] rustdoc/issue-40936.rs ... ok
building of '/nix/store/qid9x39v9c27ry7fwd0v2mcvwjmyy8zl-rustc-1.25.0.drv' timed out after 4000 seconds
cannot build derivation '/nix/store/gl8h6w8g89dibzr9q7aaa2bcbfmzfgd2-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/davhaijcm5jpa31hjqpkvbnrrlacj0a1-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/fhmq35caykx5ff62aclljhpp80a3hqyr-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/brjlnqjf6csnvabf4hjzw5dww9dg9nm6-adwaita-icon-theme-3.28.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3biq97bcckf2wzlyjryxjqf3yzgdckc0-libpeas-1.22.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m4a3x644p67nrd7s3k0gxm4adwk4q5h8-gtkd-3.6.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/m4a3x644p67nrd7s3k0gxm4adwk4q5h8-gtkd-3.6.5.drv' failed

@ThomasMader ThomasMader deleted the fix-gtkd-tilix branch August 11, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tilix package is broken
3 participants
@ThomasMader @GrahamcOfBorg @xeji