Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.30.0 -> 0.31.1 #41728

Merged
merged 1 commit into from Jun 9, 2018
Merged

matrix-synapse: 0.30.0 -> 0.31.1 #41728

merged 1 commit into from Jun 9, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

v0.31.1 fixes a security bug where the rules for message visibility were not correctly applied over federation, I interpret this as other matrix servers federating with yours could request a specific message despite no user of that other homeserver should have access to that message.

v0.30.0's main change:

Most notable change from v0.30.0 is to switch to python prometheus library to improve system stats reporting. WARNING this changes a number of prometheus metrics in a backwards-incompatible manner.

Not totally sure whether I should advise to backport to stable, the security bug really isn't nice and probably quite easy to exploit, but private conversations are hopefully using e2e encryption to protect from this. Backporting this will quite certainly break the setups of people using the prometheus monitoring system to monitor their matrix instance, but on the other hand, the intersection between NixOS, matrix and prometheus users might be near zero, or at least much less than there are people using synapse on NixOS in general.

NOTE: As of #41038, I can't run the synapse tests myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 9, 2018

@GrahamcOfBorg build matrix-synapse

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: matrix-synapse

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/lib  /nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin
patching script interpreter paths in /nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1
checking for references to /build in /nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/register_new_matrix_user'...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/hash_password'...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/synapse_port_db'...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/homeserver'...
wrapping `/nix/store/93ivagi2xjq8b8ny78qz4fk20y8dwnbf-matrix-synapse-0.31.1/bin/synctl'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/lib  /nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin
patching script interpreter paths in /nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1
checking for references to /build in /nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/hash_password'...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/homeserver'...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/register_new_matrix_user'...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/synapse_port_db'...
wrapping `/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1/bin/synctl'...
/nix/store/nmkf70clqi4cnwqcc74ksyb62s1jigm5-matrix-synapse-0.31.1

@xeji
Copy link
Contributor

xeji commented Jun 9, 2018

@GrahamcOfBorg test matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

server_postgres: exit status 0
server_sqlite: running command: sync
server_sqlite: exit status 0
test script finished in 59.30s
cleaning up
killing server_postgres (pid 593)
killing server_sqlite (pid 605)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/79szcnv0s4mylg5bbvnr529r6jmhk7x9-vm-test-run-matrix-synapse

@xeji xeji merged commit c866222 into NixOS:master Jun 9, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.matrix-synapse

Partial log (click to expand)

server_postgres: exit status 0
server_sqlite: running command: sync
server_sqlite: exit status 0
test script finished in 104.76s
cleaning up
killing server_postgres (pid 627)
killing server_sqlite (pid 640)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/k7rdl1ywa9fl3jggi3vs03zdkaz1vis3-vm-test-run-matrix-synapse

@florianjacob florianjacob deleted the matrix-synapse branch June 9, 2018 10:56
@florianjacob
Copy link
Contributor Author

@xeji thanks!

Could you tell me what I have to do so that @GrahamcOfBorg runs tests on my command?

@florianjacob florianjacob mentioned this pull request Oct 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@florianjacob @xeji @GrahamcOfBorg