Dir Open, Next, Close; DeleteDir for Windows #1084
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BraedonWooding
commented
Jun 9, 2018
•
BraedonWooding
commented
- Removed if condition in docgen to re-enable feature on windows
- As to support windows Dir struct the 'DirData' field is dependent on OS
- Implemented windows.PathIsDirectoryEmpty
- Implemented windows.RemovedDirectory
- Implemented windows.FindFirstFile
- Implemented windows.FindNextFile
- Implemented windows.FindClose
- Implemented windows.WIN32_FIND_DATA struct
- Implemented windows_util.FileSearchData containing all the data required for future searches (as well as the current file pointer and if you are at the 'end').
- Implemented windows_util.windowsPathIsDirectoryEmpty
- Implemented windows_util.windowsRemoveDirectory
- Implemented windows_util.windowsFindFirstFile
- Implemented windows_util.windowsFindNextFile
- Implemented windows_util.windowsFindClose
- Implemented os.DeleteDir
- Implemented Os.Dir.Open/Next/Close
As to support windows Dir struct the 'DirData' field is dependent on OS Implemented windows.PathIsDirectoryEmpty Implemented windows.RemovedDirectory Implemented windows.FindFirstFile Implemented windows.FindNextFile Implemented windows.FindClose Implemented windows.WIN32_FIND_DATA struct Implemented windows_util.FileSearchData containing all the data required for future searches (as well as the current file pointer and if you are at the 'end'). Implemented windows_util.windowsPathIsDirectoryEmpty Implemented windows_util.windowsRemoveDirectory Implemented windows_util.windowsFindFirstFile Implemented windows_util.windowsFindNextFile Implemented windows_util.windowsFindClose
|
@andrewrk I expect this to pass the tests now 😄, took a decent amount of time as it 'bloated' as it turned out I also had to implement DeleteDir (to get the docgen to also compile). |
|
Nice, I'll have a look at this tomorrow morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.