nixos/uvcvideo.dynctrl: Init #41737
Merged
nixos/uvcvideo.dynctrl: Init #41737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An upcoming example of dynamic controls: #41738 |
jraygauthier
force-pushed
the
jrg/uvcvideo_dynctrl_rebased
branch
from
5ac9754
to
f586ac3
Compare
Mic92
reviewed
Jun 11, 2018
|
|
||
| packages = mkOption { | ||
| type = types.listOf types.path; | ||
| default = []; |
There was a problem hiding this comment.
Can you provide an example value here? Is the module useful at all with an empty package list? If not, please remove [] as default.
There was a problem hiding this comment.
@Mic92 : Good idea. Done.
There was a problem hiding this comment.
Indeed not of much use without a value. Removed the default as well.
jraygauthier
force-pushed
the
jrg/uvcvideo_dynctrl_rebased
branch
from
f586ac3
to
84fbca9
Compare
jraygauthier
force-pushed
the
jrg/uvcvideo_dynctrl_rebased
branch
from
84fbca9
to
3dfc9cd
Compare
|
@Mic92 : Everything fine now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Needed a way to register scientific camera's uvcvideo dynamic controls to kernel driver.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)