Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/uvcvideo.dynctrl: Init #41737

Merged
merged 1 commit into from
Jun 16, 2018
Merged

nixos/uvcvideo.dynctrl: Init #41737

merged 1 commit into from
Jun 16, 2018
+111 −0

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Needed a way to register scientific camera's uvcvideo dynamic controls to kernel driver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 9, 2018
@jraygauthier
Copy link
Member Author

An upcoming example of dynamic controls: #41738

@jraygauthier jraygauthier mentioned this pull request Jun 9, 2018
Merged
8 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 9, 2018
@jraygauthier jraygauthier force-pushed the jrg/uvcvideo_dynctrl_rebased branch from 5ac9754 to f586ac3 Compare June 11, 2018 11:06
Mic92
Mic92 reviewed Jun 11, 2018
View reviewed changes
nixos/modules/hardware/video/uvcvideo/default.nix Outdated

packages = mkOption {
type = types.listOf types.path;
default = [];
Copy link
Member

@Mic92 Mic92 Jun 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an example value here? Is the module useful at all with an empty package list? If not, please remove [] as default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 : Good idea. Done.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed not of much use without a value. Removed the default as well.

@jraygauthier jraygauthier force-pushed the jrg/uvcvideo_dynctrl_rebased branch from f586ac3 to 84fbca9 Compare June 11, 2018 15:30
@jraygauthier jraygauthier force-pushed the jrg/uvcvideo_dynctrl_rebased branch from 84fbca9 to 3dfc9cd Compare June 11, 2018 15:33
@jraygauthier
Copy link
Member Author

@Mic92 : Everything fine now?

@matthewbauer matthewbauer merged commit 53a75e3 into NixOS:master Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jraygauthier @Mic92 @matthewbauer @GrahamcOfBorg