Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memcached: 1.5.5 -> 1.5.8 #41727

Merged
merged 1 commit into from Jun 8, 2018
Merged

memcached: 1.5.5 -> 1.5.8 #41727

merged 1 commit into from Jun 8, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jun 8, 2018

Motivation for this change

Backport of the (automated) version bump to address the famous UDP
amplification CVE-2018-1000115. While the issue only manifests on localhost (with our
default nixos configuration) the issue might be more relevant for people
that expose it to other hosts and only restrict the TCP access. UDP was
enabled per default, it had to be disabled. The NixOS module does only
configures the TCP port.

(cherry picked from commit 7e30cff)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@r-ryantm @andir
memcached: 1.5.5 -> 1.5.8
7536a40 
Backport of the (automated) version bump to address the famous UDP
amplification CVE-2018-1000115. While the issue only manifests on localhost (with our
default nixos configuration) the issue might be more relevant for people
that expose it to other hosts and only restrict the TCP access. UDP was
enabled per default, it had to be disabled. The NixOS module does only
configure the TCP port.

(cherry picked from commit 7e30cff)
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: memcached

Partial log (click to expand)

make[1]: Leaving directory '/build/memcached-1.5.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8
shrinking /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8/bin/memcached
gzipping man pages under /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8/bin
patching script interpreter paths in /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8
checking for references to /build in /nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8...
/nix/store/91swq1dv6gm26gic245qmppzmvppapzs-memcached-1.5.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: memcached

Partial log (click to expand)

 /nix/store/zrq8x931a6pvjj2w816y6bab45wanq39-coreutils-8.29/bin/install -c -m 644 protocol_binary.h '/nix/store/862154gw32i7p10anlcc1a8d5a6633r3-memcached-1.5.8/include/memcached'
make[3]: Leaving directory '/private/tmp/nix-build-memcached-1.5.8.drv-0/memcached-1.5.8'
make[2]: Leaving directory '/private/tmp/nix-build-memcached-1.5.8.drv-0/memcached-1.5.8'
make[1]: Leaving directory '/private/tmp/nix-build-memcached-1.5.8.drv-0/memcached-1.5.8'
post-installation fixup
gzipping man pages under /nix/store/862154gw32i7p10anlcc1a8d5a6633r3-memcached-1.5.8/share/man/
strip is /nix/store/wpnjl52wixb6jln26c9n3mfwq63pv8g4-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/862154gw32i7p10anlcc1a8d5a6633r3-memcached-1.5.8/bin
patching script interpreter paths in /nix/store/862154gw32i7p10anlcc1a8d5a6633r3-memcached-1.5.8
/nix/store/862154gw32i7p10anlcc1a8d5a6633r3-memcached-1.5.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: memcached

Partial log (click to expand)

make[1]: Leaving directory '/build/memcached-1.5.8'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8
shrinking /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8/bin/memcached
gzipping man pages under /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8/share/man/
strip is /nix/store/ppn001bfygzlqx4h50n9zgxc3kqv2d6k-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8/bin
patching script interpreter paths in /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8
checking for references to /build in /nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8...
/nix/store/wcjqh2p3r2f1ik7krxfjp0bx6gxp2n7c-memcached-1.5.8

@xeji xeji merged commit 9452b4a into NixOS:release-18.03 Jun 8, 2018
@andir andir deleted the 18.03/memcached-CVE-2018-1000115 branch June 9, 2018 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @GrahamcOfBorg @xeji @r-ryantm