Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: 4.4p19 -> 4.4p23 #41779

Merged
merged 1 commit into from Jun 15, 2018
Merged

bash: 4.4p19 -> 4.4p23 #41779

merged 1 commit into from Jun 15, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 10, 2018 •
edited

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bash

Partial log (click to expand)

gzipping man pages under /nix/store/46kcjf9wpfsqq9zmcyc02pvqch2zxj4r-bash-4.4-p23-man/share/man/
strip is /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/46kcjf9wpfsqq9zmcyc02pvqch2zxj4r-bash-4.4-p23-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/59gcsrcg8648ymga97249vmbvjr8021b-bash-4.4-p23-doc
strip is /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/59gcsrcg8648ymga97249vmbvjr8021b-bash-4.4-p23-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/1ai2pcc5s0j1hfmihabafjqrzxpp42g0-bash-4.4-p23-info
strip is /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/1ai2pcc5s0j1hfmihabafjqrzxpp42g0-bash-4.4-p23-info...
/nix/store/7k76vz4b9m5nk0ndrh5cxh53rmz95y2p-bash-4.4-p23

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bash

Partial log (click to expand)

Patching '/nix/store/0n707dh42hganyqkifgz819xr85p9c11-bash-4.4-p23-dev/lib/pkgconfig/bash.pc' includedir to output /nix/store/0n707dh42hganyqkifgz819xr85p9c11-bash-4.4-p23-dev
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/qzx7jq4clmsb0wbr0npmcsqh1wvcy66l-bash-4.4-p23/lib  /nix/store/qzx7jq4clmsb0wbr0npmcsqh1wvcy66l-bash-4.4-p23/bin
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
stripping (with command strip and flags -S) in /nix/store/0n707dh42hganyqkifgz819xr85p9c11-bash-4.4-p23-dev/lib
gzipping man pages under /nix/store/bh2hk5sqi4fbg38xac63ndy153l9a6zi-bash-4.4-p23-man/share/man/
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
strip is /nix/store/4q1c84f1ynfvsd85a932375sg0jc89v8-bootstrap-tools/bin/strip
/nix/store/qzx7jq4clmsb0wbr0npmcsqh1wvcy66l-bash-4.4-p23

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bash

Partial log (click to expand)

gzipping man pages under /nix/store/x8rj04gnwpkd6hswhg3ag7a8b8xybjm7-bash-4.4-p23-man/share/man/
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/x8rj04gnwpkd6hswhg3ag7a8b8xybjm7-bash-4.4-p23-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/0sbj92qq84xbmm4b801cwi1acs5hic3b-bash-4.4-p23-doc
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/0sbj92qq84xbmm4b801cwi1acs5hic3b-bash-4.4-p23-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/kyfbhh4wkkbd1mqj3yhv4jamnbk6hdyd-bash-4.4-p23-info
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/kyfbhh4wkkbd1mqj3yhv4jamnbk6hdyd-bash-4.4-p23-info...
/nix/store/byq52c6zm8d5i3vqq6k8ny8i3j8fkgc5-bash-4.4-p23

@dtzWill
Copy link
Member Author

dtzWill commented Jun 10, 2018

Looks pretty safe functionally but will cause many many rebuilds :). Any thoughts on when would be a good time to merge?

@lukateras lukateras merged commit 80fa195 into NixOS:staging Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @lukateras