Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiscamera: Init at 0.9.1 #41738

Merged
merged 1 commit into from Jun 10, 2018
Merged

tiscamera: Init at 0.9.1 #41738

merged 1 commit into from Jun 10, 2018

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Linux uvc drivers for the imaging source camera.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jraygauthier jraygauthier mentioned this pull request Jun 9, 2018
Merged
8 tasks
@jraygauthier
Copy link
Member Author

The uvc dynamic controls are registered through #41737

ryantm
ryantm requested changes Jun 9, 2018
View reviewed changes
pkgs/os-specific/linux/tiscamera/default.nix Outdated

src = fetchFromGitHub {
owner = "TheImagingSource";
repo = "${pname}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo = pname;

pkgs/os-specific/linux/tiscamera/default.nix Outdated
src = fetchFromGitHub {
owner = "TheImagingSource";
repo = "${pname}";
rev = "v-${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = "v-${name}";

pkgs/os-specific/linux/tiscamera/default.nix Outdated
meta = with lib; {
description = "The Linux sources and UVC firmwares for The Imaging Source cameras";
homepage = https://github.com/TheImagingSource/tiscamera;
licenses = with licenses; [ asl20 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license = with licenses; [ asl20 ];
fixes eval.

@jraygauthier
Copy link
Member Author

@ryantm : Done.

@ryantm
Copy link
Member

ryantm commented Jun 10, 2018

@gramcofborg build tiscamera

@xeji
Copy link
Contributor

xeji commented Jun 10, 2018

@GrahamcOfBorg build tiscamera

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tiscamera

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tiscamera

Partial log (click to expand)

shrinking /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib/libtcamprop.so.0.1
shrinking /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib/libtcam.so.0.9.1
shrinking /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib/libtcam-dfk73.so.0.9.1
shrinking /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib/tcam-0/libtcam-libusb.so.0.9.1
shrinking /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib/tcam-0/libtcam-v4l2.so.0.9.1
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/lib  /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1/bin
patching script interpreter paths in /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1
checking for references to /build in /nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1...
/nix/store/61j05351y94vlczprn86rs8xvkcmnv5k-tiscamera-0.9.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tiscamera

Partial log (click to expand)

shrinking /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/lib/gstreamer-1.0/libgsttcamautofocus.so
shrinking /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/lib/gstreamer-1.0/libgsttcambin.so
shrinking /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/lib/libtcam-algorithms.so.0.9.1
shrinking /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/bin/tcam-ctrl
shrinking /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/bin/dfk73udev
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/lib  /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1/bin
patching script interpreter paths in /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1
checking for references to /build in /nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1...
/nix/store/jskp2fwvhf745jp03mhw2v672q5pjhnx-tiscamera-0.9.1

@xeji xeji merged commit 1ef6d3f into NixOS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jraygauthier @ryantm @xeji @GrahamcOfBorg