Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: Fix "zfs-sync" for modern systemd #41733

Merged
merged 1 commit into from Jun 9, 2018
Merged

zfs: Fix "zfs-sync" for modern systemd #41733

merged 1 commit into from Jun 9, 2018

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Jun 9, 2018 •
edited

Motivation for this change

Modern systemd implicitly adds dependencies that conflict with wantedBy shutdown.target, causing the sync script to be silently skipped. This can (and did) cause ZFS to roll back the last few writes on reboot, causing a boot failure if that includes the system to be booted.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit bf070df into NixOS:master Jun 9, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 9, 2018

I suppose we should backport this?

@Baughn
Copy link
Contributor Author

Baughn commented Jun 9, 2018

Yes, please do.

@Mic92
Copy link
Member

Mic92 commented Jun 11, 2018

[detached HEAD cc1b088] zfs: Fix "zfs-sync" for modern systemd
Author: Svein Ove Aas sveina@gmail.com
Date: Sat Jun 9 00:06:22 2018 +0100
1 file changed, 3 insertions(+)

@Baughn Baughn deleted the nix-sync branch June 12, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Baughn @Mic92 @GrahamcOfBorg