Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: compile with libcap #41755

Merged
merged 1 commit into from Jun 9, 2018
Merged

bind: compile with libcap #41755

merged 1 commit into from Jun 9, 2018

Conversation

dudebout
Copy link
Contributor

@dudebout dudebout commented Jun 9, 2018

Motivation for this change

There is a bug in BIND, when compiled without libcap, which prevents it from running inside docker without granting extra capabilities: https://gitlab.isc.org/isc-projects/bind9/issues/321

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dudebout
bind: compile with libcap
7237198 
Additionally:

   + split native and other build inputs
   + alphabetically order dependencies
   + explicitly disable libjson support (the configure script looks for it in
     /usr, /usr/local, and /opt/local)
@xeji
Copy link
Contributor

xeji commented Jun 9, 2018

cc maintainers @peti @viric
@GrahamcOfBorg build bind

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bind

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bind

Partial log (click to expand)

strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6jwh5pdpcd47djxz97qnrp8fcknpqrvi-bind-9.12.1-P2-dnsutils/bin
patching script interpreter paths in /nix/store/6jwh5pdpcd47djxz97qnrp8fcknpqrvi-bind-9.12.1-P2-dnsutils
checking for references to /build in /nix/store/6jwh5pdpcd47djxz97qnrp8fcknpqrvi-bind-9.12.1-P2-dnsutils...
shrinking RPATHs of ELF executables and libraries in /nix/store/90ak0nq1kkffby12qvsynz0jwxmkkl2i-bind-9.12.1-P2-host
shrinking /nix/store/90ak0nq1kkffby12qvsynz0jwxmkkl2i-bind-9.12.1-P2-host/bin/host
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/90ak0nq1kkffby12qvsynz0jwxmkkl2i-bind-9.12.1-P2-host/bin
patching script interpreter paths in /nix/store/90ak0nq1kkffby12qvsynz0jwxmkkl2i-bind-9.12.1-P2-host
checking for references to /build in /nix/store/90ak0nq1kkffby12qvsynz0jwxmkkl2i-bind-9.12.1-P2-host...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bind

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/vgr6vsqbslvffyhdihv5sky45ni0hw3y-bind-9.12.1-P2-dnsutils/bin
patching script interpreter paths in /nix/store/vgr6vsqbslvffyhdihv5sky45ni0hw3y-bind-9.12.1-P2-dnsutils
checking for references to /build in /nix/store/vgr6vsqbslvffyhdihv5sky45ni0hw3y-bind-9.12.1-P2-dnsutils...
shrinking RPATHs of ELF executables and libraries in /nix/store/n6mrgixb2gbs89nlj740irps91114g82-bind-9.12.1-P2-host
shrinking /nix/store/n6mrgixb2gbs89nlj740irps91114g82-bind-9.12.1-P2-host/bin/host
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n6mrgixb2gbs89nlj740irps91114g82-bind-9.12.1-P2-host/bin
patching script interpreter paths in /nix/store/n6mrgixb2gbs89nlj740irps91114g82-bind-9.12.1-P2-host
checking for references to /build in /nix/store/n6mrgixb2gbs89nlj740irps91114g82-bind-9.12.1-P2-host...
/nix/store/1parnm6pg6rzz9mzhhdd326ikx1iw1hx-bind-9.12.1-P2

@xeji xeji merged commit 72fe3d7 into NixOS:master Jun 9, 2018
@dudebout dudebout deleted the bind-with-libcap branch July 13, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dudebout @xeji @GrahamcOfBorg