Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard-go: 0.0.20180519 -> 0.0.20180531 #41735

Merged
merged 2 commits into from Jun 9, 2018
Merged

wireguard-go: 0.0.20180519 -> 0.0.20180531 #41735

merged 2 commits into from Jun 9, 2018

Conversation

lukateras
Copy link
Member

Motivation for this change

Update wireguard-go to the latest release to sync with wireguard-tools, also assume maintainership.

@zx2c4: is there a low-volume Atom/RSS feed or mailing list I could follow for updates?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: wireguard-go

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: wireguard-go

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: wireguard-go

Partial log (click to expand)

/private/tmp/nix-build-wireguard-go-0.0.20180531.drv-0/go /private/tmp/nix-build-wireguard-go-0.0.20180531.drv-0
/private/tmp/nix-build-wireguard-go-0.0.20180531.drv-0
post-installation fixup
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nb49q8sja1gfd0x7ps34a3i8yin23fd5-wireguard-go-0.0.20180531-bin/bin
patching script interpreter paths in /nix/store/nb49q8sja1gfd0x7ps34a3i8yin23fd5-wireguard-go-0.0.20180531-bin
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/fyhgv1rpg4q0q9n9f96g1z1220yl7823-wireguard-go-0.0.20180531
/nix/store/fyhgv1rpg4q0q9n9f96g1z1220yl7823-wireguard-go-0.0.20180531/share/go/src/git.zx2c4.com/wireguard-go/tests/netns.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
/nix/store/nb49q8sja1gfd0x7ps34a3i8yin23fd5-wireguard-go-0.0.20180531-bin

@xeji xeji merged commit d43fd83 into NixOS:master Jun 9, 2018
@xeji xeji mentioned this pull request Jun 9, 2018
Closed
@lukateras lukateras deleted the wireguard-go-20180531 branch June 9, 2018 07:31
@Mic92
Copy link
Member

Mic92 commented Jun 9, 2018

@yegortimoshenko the github mirror has an atom feed: https://github.com/WireGuard/wireguard-go/releases.atom

@zx2c4
Copy link
Contributor

zx2c4 commented Jun 11, 2018 

   postPatch = ''
     # Replace local imports so that go tools do not trip on them
     find . -name '*.go' -exec sed -i '/import (/,/)/s@"./@"${goPackagePath}/@' {} \;
   '';

This block should be removed, as it's no longer needed.

Considering the history of this .nix, I'd suggest you go through it line by line and be sure it's correct.

@zx2c4
Copy link
Contributor

zx2c4 commented Jun 11, 2018

Re:automated bumps -- you can parse either one of these files:

https://build.wireguard.com/distros.json
https://build.wireguard.com/distros.txt

For this package, you want the "upstream-go" one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukateras @GrahamcOfBorg @Mic92 @zx2c4 @xeji