linux-hardkernel: Init at 4.14.47-139 #41782

qolii · 2018-06-10T07:16:46Z

Motivation for this change

This introduces a build for the hardkernel vendor kernel tree, to support hardkernel hardware (e.g. the odroid series of SBCs).

Things done

I have built and tested this kernel on my Odroid HC1, using kernelPackages = pkgs.linuxPackages_hardkernel_latest. No problems encountered, but no further devices tested.

I just looked at existing linux kernel instances and duplicated the simplest I saw with the minimum novelty I could think of. I might definitely have missed something. Design advice is welcome.

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

andrew-d · 2018-06-10T09:03:39Z

If you're interested, I had a similar-ish config that also automatically splits version numbers:

  # modDirVersion needs to be x.y.z.
  modDirVersion = head (stdenv.lib.splitString "-" version);

  # branchVersion needs to be x.y.
  extraMeta.branch = with stdenv.lib; concatStrings (intersperse "." (take 2 (splitString "." modDirVersion)));

And, thanks for submitting this PR! I've also been running NixOS on a ODROID HC2 for a couple months now with no trouble, but never got around to submitting a PR for kernel support - much appreciated 😀

qolii · 2018-06-11T05:41:47Z

@andrew-d, no problem! :)

I saw there are such tricks in the other kernel .nix files as well. But, is it a little bit overkill? It doesn't really provide much useful abstracting power in this case, and I think it does make something simple harder to read. But I guess it's only small. I'm happy to change it if feelings are strong.

andrew-d · 2018-06-11T05:43:35Z

I'm happy to change it if feelings are strong.

No strong feelings, no - just mentioning it if you were interested! 👍

qolii · 2018-06-11T05:45:42Z

Awesome, thanks!

qolii · 2018-06-11T07:22:42Z

Cc: @dezgeg, possibly.

andrew-d · 2018-06-12T07:56:22Z

pkgs/top-level/all-packages.nix

@@ -13603,6 +13603,13 @@ with pkgs;
      ];
  };

+  linux_hardkernel_4_14 = callPackages ../os-specific/linux/kernel/linux-hardkernel-4.14.nix {


Another thing I just noticed; do you want callPackages here, or callPackage (no s) like the other kernels?

Ugh, you're totally right. Thanks! Fixed.

dezgeg · 2018-06-15T13:57:49Z

pkgs/os-specific/linux/kernel/linux-hardkernel-4.14.nix

+  # branchVersion needs to be x.y. 
+  extraMeta.branch = "4.14";
+
+  src = fetchurl {


This should use fetchFromGitHub to avoid possibly nondeterministic GitHub tarballs.

Looks good otherwise.

Ugh, is nothing sacred!! I assumed GitHub's tarballs at least would be deterministic.

Will fix. Thanks for looking!

Uhh, sorry about this, can you help me? I've changed it to

src = fetchFromGitHub { owner = "hardkernel"; repo = "linux"; rev = version; sha256 = "1nxgd29y9wmifm11pjcdpd2y293p0dgi0x5ycis55miy97n0f5zy"; };

which, as far as I can tell, is roughly the right way to do things. (The hash is wrong, but I was going to try to build it and then fix up the hash when it complained about it.)

However, I get the result that, when I run nixos-rebuild, I get:

these derivations will be built: /nix/store/5jcd3rxy9xmql16vvrx8vspinibqxmn2-source.drv /nix/store/hq0l73vjjy7py4g7cwrbd79mzzfnqvva-linux-config-4.14.47-139.drv /nix/store/kxwdk2f2lks3cannzqsw1iv634c75b8f-linux-4.14.47-139.drv /nix/store/phx3p9afjlkr1sl3pd194m4iq9j5n3q1-kernel-modules.drv /nix/store/sas9zlmpw0msri87mzx9qg1x9mh4vb3w-firmware.drv /nix/store/fa9dm9bbilinl9zkpw83yshvgrpsh7sz-kernel-modules-shrunk.drv /nix/store/02360f07416jlzgpkfqbn76zmrpl63z0-stage-1-init.sh.drv /nix/store/gigx079yqhiam6m9w7mxqkk1imwy2zwg-etc-nixos.conf.drv /nix/store/ic84x39phcwxxk439awdns9bymfyi05w-etc.drv /nix/store/lp5hwcwfks7f7iv5mfnjb9dhkswzl6kf-initrd.drv /nix/store/kaibkzq676y6alxs2nxwwmiwd3d9nncb-nixos-system-gospel-18.09.git.d6422c6.drv building '/nix/store/5jcd3rxy9xmql16vvrx8vspinibqxmn2-source.drv'... trying https://github.com/hardkernel/linux/archive/4.14.47-139.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 129 0 129 0 0 390 0 --:--:-- --:--:-- --:--:-- 390

at which point, it hangs forever. No error. That tar.gz path itself is fine:

# wget https://github.com/hardkernel/linux/archive/4.14.47-139.tar.gz [successful noises]

works fine. However, I'm not sure if this is relevant, but:

# curl https://github.com/hardkernel/linux/archive/4.14.47-139.tar.gz <html><body>You are being <a href="https://codeload.github.com/hardkernel/linux/tar.gz/4.14.47-139">redirected</a>.</body></html>

Anyway, I expect am making an obvious mistake! Any idea?

qolii · 2018-06-18T23:35:34Z

Alright, done. It wasn't hanging after all, just taking ages.

Seems to work for me.

Mic92 · 2018-08-05T16:17:40Z

Please restrict the build to aarch64. It breaks my nix-review for kernel modules, because nix is trying to build it on x86_64.

qolii · 2018-08-13T19:54:16Z

@Mic92, sorry for the delay here. What is the most appropriate way to do this?

I see other kernel expressions using extraMeta.hydraPlatforms = [ ]; and extraMeta.hydraPlatforms = [ "armv7l-linux" ];. Would one of these do the trick?

Mic92 · 2018-08-16T11:32:20Z

I assume:

extraMeta.hydraPlatforms = [ "armv7l-linux" ];

would do the trick then.

Mic92 · 2018-08-16T11:33:52Z

Also something like extraMeta.platforms would be better because then also nix-review does not attempt to build it.

Mic92 · 2018-08-16T11:36:52Z

done in 995d005

(cherry picked from commit 07e8402)

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500 labels Jun 10, 2018

andrew-d reviewed Jun 12, 2018

View reviewed changes

Init: linux-hardkernel-4.14

2af60e2

qolii force-pushed the linux_hardkernel branch from c846696 to 2af60e2 Compare June 12, 2018 16:41

dezgeg reviewed Jun 15, 2018

View reviewed changes

Update to use fetchFromGitHub.

0ea188d

dezgeg merged commit 07e8402 into NixOS:master Jun 19, 2018

andrew-d pushed a commit to andrew-d/nixpkgs that referenced this pull request Sep 22, 2018

linux-hardkernel: Init at 4.14.47-139 (NixOS#41782)

9a8aa81

(cherry picked from commit 07e8402)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linux-hardkernel: Init at 4.14.47-139 #41782

linux-hardkernel: Init at 4.14.47-139 #41782

qolii commented Jun 10, 2018 •

edited

andrew-d commented Jun 10, 2018

qolii commented Jun 11, 2018

andrew-d commented Jun 11, 2018

qolii commented Jun 11, 2018

qolii commented Jun 11, 2018

andrew-d Jun 12, 2018

qolii Jun 12, 2018

dezgeg Jun 15, 2018

qolii Jun 15, 2018

qolii Jun 18, 2018

qolii commented Jun 18, 2018

Mic92 commented Aug 5, 2018 •

edited

qolii commented Aug 13, 2018 •

edited

Mic92 commented Aug 16, 2018

Mic92 commented Aug 16, 2018

Mic92 commented Aug 16, 2018

linux-hardkernel: Init at 4.14.47-139 #41782

linux-hardkernel: Init at 4.14.47-139 #41782

Conversation

qolii commented Jun 10, 2018 • edited

Motivation for this change

Things done

andrew-d commented Jun 10, 2018

qolii commented Jun 11, 2018

andrew-d commented Jun 11, 2018

qolii commented Jun 11, 2018

qolii commented Jun 11, 2018

andrew-d Jun 12, 2018

Choose a reason for hiding this comment

qolii Jun 12, 2018

Choose a reason for hiding this comment

dezgeg Jun 15, 2018

Choose a reason for hiding this comment

qolii Jun 15, 2018

Choose a reason for hiding this comment

qolii Jun 18, 2018

Choose a reason for hiding this comment

qolii commented Jun 18, 2018

Mic92 commented Aug 5, 2018 • edited

qolii commented Aug 13, 2018 • edited

Mic92 commented Aug 16, 2018

Mic92 commented Aug 16, 2018

Mic92 commented Aug 16, 2018

qolii commented Jun 10, 2018 •

edited

Mic92 commented Aug 5, 2018 •

edited

qolii commented Aug 13, 2018 •

edited