Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfsprogs: swap src url to HTTPS #41774

Merged
merged 1 commit into from Jun 10, 2018
Merged

xfsprogs: swap src url to HTTPS #41774

merged 1 commit into from Jun 10, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 9, 2018 •
edited

This swaps the fetchgit call to be more consistent with the majority of other
NixPkgs fetchgit calls. Moreover, almost every network will be able to do HTTPS,
while some enterprise networks may limit external SSH access.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bhipple
xfsprogs: swap src url to HTTPS
5cc335c 
This swaps the fetchgit call to be more consistent with the majority of other
NixPkgs fetchgit calls. Moreover, almost every network will be able to do HTTPS,
while some enterprise networks may limit external SSH access.
@bhipple
Copy link
Contributor Author

bhipple commented Jun 9, 2018

@GrahamcOfBorg build xfsprogs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xfsprogs

Partial log (click to expand)

these paths will be fetched (0.73 MiB download, 2.44 MiB unpacked):
  /nix/store/20cmr3fk8p8740z1bkws0hp2vfqmq6xl-xfsprogs-4.14.0-bin
  /nix/store/hq713w7rpd1gpxi3rv9davr2pjyiqm24-xfsprogs-4.14.0
copying path '/nix/store/hq713w7rpd1gpxi3rv9davr2pjyiqm24-xfsprogs-4.14.0' from 'https://cache.nixos.org'...
copying path '/nix/store/20cmr3fk8p8740z1bkws0hp2vfqmq6xl-xfsprogs-4.14.0-bin' from 'https://cache.nixos.org'...
/nix/store/20cmr3fk8p8740z1bkws0hp2vfqmq6xl-xfsprogs-4.14.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xfsprogs

Partial log (click to expand)

/nix/store/awn7im9zraf3yq7m9zq1l390d31rmam1-xfsprogs-4.14.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xfsprogs

Partial log (click to expand)

/nix/store/20cmr3fk8p8740z1bkws0hp2vfqmq6xl-xfsprogs-4.14.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xfsprogs

Partial log (click to expand)

/nix/store/awn7im9zraf3yq7m9zq1l390d31rmam1-xfsprogs-4.14.0-bin

@matthewbauer matthewbauer merged commit e465cc7 into NixOS:master Jun 10, 2018
@bhipple bhipple deleted the xfsprogs-src-url branch June 12, 2018 01:23
@bhipple bhipple mentioned this pull request Jun 12, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @matthewbauer