Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fftw: support multiple src URLs #41773

Merged
merged 1 commit into from Jun 10, 2018
Merged

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 9, 2018

The fftw download page provides both an HTTP and FTP endpoint for downloading release tarballs:
http://fftw.org/download.html

Since some users may have difficulty fetching via FTP through corporate
firewalls, we should provide the option to get it over HTTP as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The fftw download page provides both an HTTP and FTP endpoint for downloading release tarballs:
http://fftw.org/download.html

Since some users may have difficulty fetching via FTP through corporate
firewalls, we should provide the option to get it over HTTP as well.
@bhipple
Copy link
Contributor Author

bhipple commented Jun 9, 2018

@GrahamcOfBorg build fftw

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fftw

Partial log (click to expand)

/nix/store/k6s5y6cx2z4jz43hd4fcwvviycc7ln2q-fftw-double-3.3.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fftw

Partial log (click to expand)

/nix/store/zhhpg36794mbh4cwa181503hzw26fagp-fftw-double-3.3.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fftw

Partial log (click to expand)

/nix/store/zhhpg36794mbh4cwa181503hzw26fagp-fftw-double-3.3.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fftw

Partial log (click to expand)

/nix/store/k6s5y6cx2z4jz43hd4fcwvviycc7ln2q-fftw-double-3.3.8

@FRidh FRidh merged commit bd991be into NixOS:master Jun 10, 2018
@bhipple bhipple deleted the fix/fftw-src-url branch June 12, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants