sequeler: 0.5.4 -> 0.5.5 #41785

etu · 2018-06-10T09:00:17Z

Motivation for this change

Changelog: https://github.com/Alecaddd/sequeler/releases/tag/v0.5.5

They also happened to switch away from cmake.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

cc @jtojnar

GrahamcOfBorg · 2018-06-10T09:14:34Z

Failure on x86_64-linux (full log)

Attempted: sequeler

Partial log (click to expand)

Installing /build/source/data/assets/icons/128x128/com.github.alecaddd.sequeler.svg to /nix/store/78zpn1z3ppffdpq8hix4lgmhd1716hhj-sequeler-0.5.5/share/icons/hicolor/scalable/apps
Installing /build/source/schemas/com.github.alecaddd.sequeler.gschema.xml to /nix/store/78zpn1z3ppffdpq8hix4lgmhd1716hhj-sequeler-0.5.5/share/glib-2.0/schemas
Running custom install script '/nix/store/rsa1rsd6c6szy0dmi61599b33aqiy269-python3-3.6.5/bin/python3.6m /nix/store/3pihsh6nsn4nwy71hvz1p05fwj3dbk5c-meson-0.46.1/bin/meson --internal gettext install --subdir=po --localedir=share/locale --pkgname=com.github.alecaddd.sequeler'
Running custom install script '/usr/bin/env python3 /build/source/meson/post_install.py'
Failed to run install script '/usr/bin/env python3 /build/source/meson/post_install.py'
FAILED: meson-install
/nix/store/rsa1rsd6c6szy0dmi61599b33aqiy269-python3-3.6.5/bin/python3.6m /nix/store/3pihsh6nsn4nwy71hvz1p05fwj3dbk5c-meson-0.46.1/bin/meson --internal install /build/source/build/meson-private/install.dat
ninja: build stopped: subcommand failed.
builder for '/nix/store/ms4zrx1w5gzl83n7xhq5bcbwjaqld1fj-sequeler-0.5.5.drv' failed with exit code 1
error: build of '/nix/store/ms4zrx1w5gzl83n7xhq5bcbwjaqld1fj-sequeler-0.5.5.drv' failed

etu · 2018-06-10T09:20:41Z

I'm looking into that build failure.

GrahamcOfBorg · 2018-06-10T10:14:11Z

Failure on aarch64-linux (full log)

Attempted: sequeler

Partial log (click to expand)

'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
'+fp' is not a recognized feature for this target (ignoring feature)
building of '/nix/store/vhmf28hfxpzxa86mja42pi0yd97div6q-rustc-1.26.2.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/560k72x3gw1gbis2fhxw2dsd9shsivc8-cargo-1.26.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fa14m90h5firblf1m8qf1qcgww51f3fq-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wqwg410fnw9iaym374r8zb3jd7wky8px-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n8156srhykwl9n1fwripqi1a80469ry6-sequeler-0.5.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/n8156srhykwl9n1fwripqi1a80469ry6-sequeler-0.5.5.drv' failed

jtojnar · 2018-06-10T13:34:35Z

You might need to add postPatch with patchShebangs on the install script.

etu · 2018-06-10T19:53:42Z

patchShebangs think the file is fine as it is.

  postPatch = ''
    head -n 1 /build/source/meson/post_install.py
    patchShebangs /build/source/meson/post_install.py
    head -n 1 /build/source/meson/post_install.py
  '';

prints this as part of the output

#!/usr/bin/env python3
patching script interpreter paths in /build/source/meson/post_install.py
#!/usr/bin/env python3

so I'll dig around a bit more

jtojnar · 2018-06-10T19:55:40Z

You might need to add python3 to buildInputs, or chmod +x the file.

jtojnar · 2018-06-10T20:13:53Z

pkgs/applications/misc/sequeler/default.nix

+
+  postPatch = ''
+    # /usr/bin/env is not available in the sandbox, and patchShebangs ignores it
+    substituteInPlace /build/source/meson/post_install.py                      \


patchShebangs definitely works with env

So how come it doesn't change it? :(

Oh, it needs to be executable before patchShebangs runs on the file. Now it works.

jtojnar · 2018-06-10T20:58:22Z

pkgs/applications/misc/sequeler/default.nix

+  buildInputs = [ gtk3 glib granite libgee sqlGda gtksourceview libxml2 libsecret ];
+
+  postPatch = ''
+    chmod +x /build/source/meson/post_install.py


Just use meson/post_install.py path.

Changelog: https://github.com/Alecaddd/sequeler/releases/tag/v0.5.5 They also happened to switch away from cmake.

jtojnar · 2018-06-11T01:48:41Z

@GrahamcOfBorg build sequeler

GrahamcOfBorg · 2018-06-11T01:49:23Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sequeler

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-06-11T01:52:10Z

Success on x86_64-linux (full log)

Attempted: sequeler

Partial log (click to expand)

glibPreFixupPhase
glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5/bin/com.github.alecaddd.sequeler
shrinking RPATHs of ELF executables and libraries in /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5
shrinking /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5/bin/.com.github.alecaddd.sequeler-wrapped
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5/bin
patching script interpreter paths in /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5
checking for references to /build in /nix/store/w73sak9b5l2pds7gjz0i2h1v7cavqpwp-sequeler-0.5.5...

GrahamcOfBorg · 2018-06-11T01:58:40Z

Failure on aarch64-linux (full log)

Attempted: sequeler

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5
shrinking /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5/bin/granite-demo
shrinking /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5/lib/libgranite.so.4.0
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5/lib  /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5/bin
patching script interpreter paths in /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5
checking for references to /build in /nix/store/2mgj3fsz7xiq05zkhp6isjzb4mnl2qdh-granite-0.5...
cannot build derivation '/nix/store/0l9sqrqr672m5iaprdnkxl1p4wn2xnlg-sequeler-0.5.5.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0l9sqrqr672m5iaprdnkxl1p4wn2xnlg-sequeler-0.5.5.drv' failed

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jun 10, 2018

etu changed the title ~~sequeler: 0.5.4 -> 0.5.5~~ [WIP] sequeler: 0.5.4 -> 0.5.5 Jun 10, 2018

pSub added the 2.status: work-in-progress label Jun 10, 2018

etu force-pushed the sequeler-update branch from 486b597 to cf62f5d Compare June 10, 2018 20:05

jtojnar reviewed Jun 10, 2018

View reviewed changes

etu force-pushed the sequeler-update branch from cf62f5d to dae1f58 Compare June 10, 2018 20:22

etu changed the title ~~[WIP] sequeler: 0.5.4 -> 0.5.5~~ sequeler: 0.5.4 -> 0.5.5 Jun 10, 2018

etu force-pushed the sequeler-update branch from dae1f58 to 8130a45 Compare June 10, 2018 20:23

jtojnar requested changes Jun 10, 2018

View reviewed changes

sequeler: 0.5.4 -> 0.5.5

530b287

Changelog: https://github.com/Alecaddd/sequeler/releases/tag/v0.5.5 They also happened to switch away from cmake.

etu force-pushed the sequeler-update branch from 8130a45 to 530b287 Compare June 10, 2018 21:03

jtojnar approved these changes Jun 11, 2018

View reviewed changes

jtojnar merged commit e7b304e into NixOS:master Jun 11, 2018

etu deleted the sequeler-update branch June 18, 2018 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sequeler: 0.5.4 -> 0.5.5 #41785

sequeler: 0.5.4 -> 0.5.5 #41785

etu commented Jun 10, 2018 •

edited

GrahamcOfBorg commented Jun 10, 2018

etu commented Jun 10, 2018

GrahamcOfBorg commented Jun 10, 2018

jtojnar commented Jun 10, 2018

etu commented Jun 10, 2018

jtojnar commented Jun 10, 2018

jtojnar Jun 10, 2018

etu Jun 10, 2018

etu Jun 10, 2018

jtojnar Jun 10, 2018

jtojnar commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

sequeler: 0.5.4 -> 0.5.5 #41785

sequeler: 0.5.4 -> 0.5.5 #41785

Conversation

etu commented Jun 10, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Jun 10, 2018

etu commented Jun 10, 2018

GrahamcOfBorg commented Jun 10, 2018

jtojnar commented Jun 10, 2018

etu commented Jun 10, 2018

jtojnar commented Jun 10, 2018

jtojnar Jun 10, 2018

Choose a reason for hiding this comment

etu Jun 10, 2018

Choose a reason for hiding this comment

etu Jun 10, 2018

Choose a reason for hiding this comment

jtojnar Jun 10, 2018

Choose a reason for hiding this comment

jtojnar commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

GrahamcOfBorg commented Jun 11, 2018

etu commented Jun 10, 2018 •

edited