Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alsa: setup mirrors for src downloads #41761

Merged
merged 1 commit into from Jun 10, 2018
Merged

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jun 9, 2018

This commit adds a list of supported mirrors for all alsa projects, as described
on the download section of the alsa-project hompage:
http://alsa-project.org/main/index.php/Download

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This commit adds a list of supported mirrors for all alsa projects, as described
on the download section of the alsa-project hompage:
http://alsa-project.org/main/index.php/Download
@@ -28,7 +25,7 @@ stdenv.mkDerivation rec {
'';

meta = {
homepage = http://www.alsa-project.org/main/index.php/Main_Page;
homepage = http://www.alsa-project.org/;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making this one consistent with all the other alsa-project homepage meta attributes.

# Alsa Project
alsa = [
ftp://ftp.alsa-project.org/pub/
http://alsa.cybermirror.org/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, this one is not listed on the upstream project page:
http://alsa-project.org/main/index.php/Download

and it appears to be "temporarily down for maintenance and will be back shortly":
http://alsa.cybermirror.org/

It's also worth noting that many enterprise firewalls and system configurations are generally more suspicious / less tolerant of FTP traffic than HTTP traffic, and may block it entirely for security considerations. Whenever possible it's nice to provide some HTTP alternatives!

@oxij
Copy link
Member

oxij commented Jun 9, 2018

LGTM.

@matthewbauer
Copy link
Member

Is that "rebuild-darwin-stdenv" label correct?

@bhipple
Copy link
Contributor Author

bhipple commented Jun 10, 2018

I don't see how it could be; I'm not changing any shas, so in theory this shouldn't rebuild anything at all . . .

@LnL7
Copy link
Member

LnL7 commented Jun 10, 2018

@GrahamcOfBorg eval

@xeji xeji merged commit d81ab0a into NixOS:master Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants