Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hacking.xml #967

Merged
merged 3 commits into from Jun 15, 2018
Merged

Update hacking.xml #967

merged 3 commits into from Jun 15, 2018

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Jun 9, 2018

No description provided.

FRidh
FRidh suggested changes Jun 12, 2018
View reviewed changes
doc/manual/hacking.xml Outdated

<screen>
# this will not work, because sys.stdout is substituted with log file
print 'asdf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parentheses

doc/manual/hacking.xml Outdated

# this will work
self.log('asdf')
import sys; print >> sys.__stdout__, 'asdf'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3 compatibility.

@srghma
Copy link
Contributor Author

srghma commented Jun 12, 2018

@FRidh done

@rbvermaa rbvermaa merged commit 28231a1 into NixOS:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srghma @FRidh @rbvermaa