Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ycmd: 2017-11-05 -> 2018-06-14 #42080

Merged
merged 1 commit into from Jun 17, 2018
Merged

ycmd: 2017-11-05 -> 2018-06-14 #42080

merged 1 commit into from Jun 17, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 15, 2018

Fixes build with boost 1.67

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested with vim/youcompleteme
  • Fits CONTRIBUTING.md.

@LnL7
ycmd: 2017-11-05 -> 2018-06-14
04e4733 
Fixes build with boost 1.67
LnL7
LnL7 commented Jun 15, 2018
View reviewed changes
pkgs/development/tools/misc/ycmd/default.nix
@@ -24,8 +24,6 @@ stdenv.mkDerivation rec {
${python.interpreter} build.py --system-libclang --clang-completer --system-boost
'';

patches = [ ./dont-symlink-clang.patch ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell the patch isn't necessary anymore.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ycmd

Partial log (click to expand)

/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14/lib/ycmd/libclang.dylib: fixing dylib
/nix/store/favygpap9rdbap030qp82r8l983zz190-ycmd-2018-06-14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ycmd

Partial log (click to expand)

strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib  /nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/bin
patching script interpreter paths in /nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib/ycmd/third_party/python-future/check_rst.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib/ycmd/third_party/bottle/docs/_locale/update.sh: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib/ycmd/third_party/bottle/test/travis_setup.sh: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib/ycmd/third_party/jedi/travis_install.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14/lib/ycmd/third_party/jedi/deploy-master.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14...
/nix/store/0kfnkpisyws09s1njbcfn01a2za3l82q-ycmd-2018-06-14

bhipple
bhipple reviewed Jun 15, 2018
View reviewed changes
pkgs/development/tools/misc/ycmd/default.nix
url = "git://github.com/Valloric/ycmd.git";
rev = "0ca16e7ba3a9078b697befdce64104e61829aa3b";
sha256 = "0bs94iv521ac2n53n3k8mw3s6v0hi3hhxhjsr0ips3n99al8wndi";
url = "https://github.com/Valloric/ycmd.git";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for swapping to HTTPS! A lot of corporate networks and firewalls block SSH and FTP traffic from third party sites, but let HTTPS through; I was going to submit a PR to swap the url for ycmd but as always the wonderful Nix community is one step ahead 👍

@bhipple
Copy link
Contributor

bhipple commented Jun 15, 2018

LGTM

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ycmd

Partial log (click to expand)

/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/debian/rules: interpreter directive changed from "/usr/bin/make -f" to "/nix/store/3xrsm93wjp9zgc2yprba4g3x1wfr69v6-gnumake-4.2.1/bin/make -f"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/nvim/pathogen_update.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/nvim/symlink.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/nvim/update.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/vim/pathogen_update.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/vim/symlink.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3/share/go/src/github.com/nsf/gocode/vim/update.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/f3jsw840x20wfnddysb9vc0f781k3ca3-gocode-20170903-c7fddb3...
cannot build derivation '/nix/store/p1cpjj2wb3lq20ldbsi3b8iqh7qk8vji-ycmd-2018-06-14.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p1cpjj2wb3lq20ldbsi3b8iqh7qk8vji-ycmd-2018-06-14.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 17, 2018

@GrahamcOfBorg build vimPlugins.youcompleteme

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vimPlugins.youcompleteme

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16
/nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/sh"
/nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/print_todos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/.circleci/install_dependencies.sh: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16...
/nix/store/2lmck92ddyxqi5ikm2skmwmbq5x6aknz-vimplugin-youcompleteme-2018-04-16

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: vimPlugins.youcompleteme

Partial log (click to expand)

configuring
building
installing
post-installation fixup
strip is /nix/store/8q05v40n0f7amgw70pk6bkb23r7hrzgn-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/x302yiy6cwwavh280sh4idy7vyk01clx-vimplugin-youcompleteme-2018-04-16
/nix/store/x302yiy6cwwavh280sh4idy7vyk01clx-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/sh"
/nix/store/x302yiy6cwwavh280sh4idy7vyk01clx-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/print_todos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/bash"
/nix/store/x302yiy6cwwavh280sh4idy7vyk01clx-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/.circleci/install_dependencies.sh: interpreter directive changed from "/bin/bash" to "/nix/store/7jlpy03vrh1v74b6rnrclbqc9s40ixkg-bash-4.4-p19/bin/bash"
/nix/store/x302yiy6cwwavh280sh4idy7vyk01clx-vimplugin-youcompleteme-2018-04-16

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vimPlugins.youcompleteme

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16
/nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/print_todos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
/nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/install.sh: interpreter directive changed from "/bin/sh" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/sh"
/nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16/share/vim-plugins/youcompleteme/.circleci/install_dependencies.sh: interpreter directive changed from "/bin/bash" to "/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16...
/nix/store/lcbdvxchh7m192ddw9wywshl315q797m-vimplugin-youcompleteme-2018-04-16

@xeji xeji merged commit a2a8375 into NixOS:master Jun 17, 2018
@LnL7 LnL7 deleted the ycmd branch June 17, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @GrahamcOfBorg @bhipple @xeji