lice: init at 0.4 #42108
Merged
lice: init at 0.4 #42108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pSub
requested changes
Jun 16, 2018
pkgs/tools/misc/lice/default.nix
Outdated
| src = fetchFromGitHub { | ||
| owner = "licenses"; | ||
| repo = "lice"; | ||
| rev = "71635c2544d5edf9e93af4141467763916a86624"; |
There was a problem hiding this comment.
Please use the tag corresponding to the release. In this case rev = version should work.
pkgs/tools/misc/lice/default.nix
Outdated
|
|
||
| package = "lice"; | ||
| version = "0.4"; | ||
| name = "${package}-${version}"; |
There was a problem hiding this comment.
Nitpick: Why not name = "lice-${version}". You don't use package anywhere else.
There was a problem hiding this comment.
cargo-culted from a default.nix for personal project. Will be fixed.
pkgs/tools/misc/lice/default.nix
Outdated
| }; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = ""; |
pkgs/tools/misc/lice/default.nix
Outdated
|
|
||
| meta = with stdenv.lib; { | ||
| description = ""; | ||
| longDescription = '' |
There was a problem hiding this comment.
If you don't want to provide a longDescription just omit this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
liceutility is useful in development to automatically generateLICENSEfiles.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)