New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.h5py: 2.7.1 -> 2.8.0 #41581
Conversation
Looks good to me. Lets see how the build goes. @GrahamcOfBorg build pythonPackages.h5py python3Packages.h5py |
Success on x86_64-linux (full log) Attempted: pythonPackages.h5py, python3Packages.h5py Partial log (click to expand)
|
I ran nox-review but some packages failed to build. Not sure if they were failing anyway before this change... |
Failure on aarch64-linux (full log) Attempted: pythonPackages.h5py, python3Packages.h5py Partial log (click to expand)
|
@@ -30,18 +30,13 @@ in buildPythonPackage rec { | |||
|
|||
preBuild = if mpiSupport then "export CC=${mpi}/bin/mpicc" else ""; | |||
|
|||
checkInputs = optional (isPy26 || isPy27) unittest2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isPy26
test is obsolete, we don't have python26 in nixpkgs anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, removed.
5095874
to
083300e
Compare
@GrahamcOfBorg build pythonPackages.h5py python3Packages.h5py |
Success on x86_64-darwin (full log) Attempted: pythonPackages.h5py, python3Packages.h5py Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: pythonPackages.h5py, python3Packages.h5py Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: pythonPackages.h5py, python3Packages.h5py Partial log (click to expand)
|
Edward and tflearn were broken before. |
Motivation for this change
Upgrade h5py.
(I'm running the nox-review at the moment but I guess it can take a very long time.)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)