Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fvwm: 2.6.7 -> 2.6.8 #41565

Merged
merged 1 commit into from Jun 11, 2018
Merged

fvwm: 2.6.7 -> 2.6.8 #41565

merged 1 commit into from Jun 11, 2018

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jun 6, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/fvwm/versions.

These checks were done:

  • built on NixOS
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm2 passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-perllib passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-convert-2.6 passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-xlock passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-directory passed the binary check.
  • Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-desktop had a zero exit code or showed the expected version
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-headlines passed the binary check.
  • Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/xpmroot had a zero exit code or showed the expected version
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/FvwmCommand passed the binary check.
  • Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-root had a zero exit code or showed the expected version
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-config passed the binary check.
  • /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-bug passed the binary check.
  • 10 of 13 passed binary check by having a zero exit code.
  • 3 of 13 passed binary check by having the new version present in output.
  • found 2.6.8 with grep in /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8
  • directory tree listing: https://gist.github.com/94e21d8ab3a4808980c94f1fbb20f1b6
  • du listing: https://gist.github.com/6db3d3e079f7808b93a1bbc20e5f396e

meta.description for fvwm is: '"A multiple large virtual desktop window manager"'.

cc @edanaher for testing.

Experimental: this build is cached with Cachix. To use the cache follow these experimental instructions:

One time setup in nixpkgs Git checkout:

cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:

git fetch r-ryantm && git checkout f85b37514af173f30d2f2efb660bfe8573532961 && nix-shell --pure -I nixpkgs=. -p fvwm

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.

This update was made based on information from https://repology.org/metapackage/fvwm/versions.

These checks were done:

- built on NixOS
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm2 passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-perllib passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-convert-2.6 passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-xlock passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-directory passed the binary check.
- Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-desktop had a zero exit code or showed the expected version
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-menu-headlines passed the binary check.
- Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/xpmroot had a zero exit code or showed the expected version
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/FvwmCommand passed the binary check.
- Warning: no invocation of /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-root had a zero exit code or showed the expected version
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-config passed the binary check.
- /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-bug passed the binary check.
- 10 of 13 passed binary check by having a zero exit code.
- 3 of 13 passed binary check by having the new version present in output.
- found 2.6.8 with grep in /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8
- directory tree listing: https://gist.github.com/94e21d8ab3a4808980c94f1fbb20f1b6
- du listing: https://gist.github.com/6db3d3e079f7808b93a1bbc20e5f396e
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fvwm

Partial log (click to expand)

gzipping man pages under /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/libexec  /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin
patching script interpreter paths in /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8
/nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmTalk: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmTile: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmCascade: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-config: interpreter directive changed from "/bin/sh" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh"
/nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8/bin/fvwm-bug: interpreter directive changed from "/bin/sh -" to "/nix/store/qckzjk3406va7h6s40cy9s75z2w715rq-bash-4.4-p19/bin/sh -"
checking for references to /build in /nix/store/kycw0a7gqxh0v7lxq001j9sjysnz1v6h-fvwm-2.6.8...

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: fvwm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fvwm

Partial log (click to expand)

strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/libexec  /nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/bin
patching script interpreter paths in /nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmTile: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmCascade: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/libexec/fvwm/2.6.8/FvwmTalk: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/bin/fvwm-bug: interpreter directive changed from "/bin/sh -" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh -"
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8/bin/fvwm-config: interpreter directive changed from "/bin/sh" to "/nix/store/9rv2bzx7jz6wjbaxij5qq580qvzksj4i-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8...
/nix/store/jjv0s5pgid3mw4hp6zjf3ix4ymarr2f1-fvwm-2.6.8

@edanaher
Copy link
Contributor

edanaher commented Jun 8, 2018

Looks like a fairly minor release, and it Works for Me. It does restart X, though, which is annoying. I haven't looked too deeply into the window manager setup; is there a way to prevent X from restarting (and just keep running the old fvwm until X restarts for some other reason)? (Or, is there any effort in the works to warn what services will be restarted by a nixos-rebuild upgrade? That seems like a reasonable thing to do in general...)

Also, according to the release notes, "fvwm-menu-desktop(1) now requires python3 as an explicit dependency." We should probably be pulling in python3 for this, but given that it currently doesn't work in fvwm 2.6.7, it can be a separate PR.

@xeji
Copy link
Contributor

xeji commented Jun 11, 2018

@edanaher thanks for testing.

is there a way to prevent X from restarting (and just keep running the old fvwm until X restarts for some other reason)?

None that I'm aware of, unfortunately.

warn what services will be restarted by a nixos-rebuild upgrade

You can test that with nixos-rebuild dry-activate, see nixos-rebuild(8)

We should probably be pulling in python3 for this, but given that it currently doesn't work in fvwm 2.6.7, it can be a separate PR.

Agreed.

@xeji xeji merged commit c41705f into NixOS:master Jun 11, 2018
@r-ryantm r-ryantm deleted the auto-update/fvwm branch June 11, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants