Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages: use opaline instead of opam-installer #41591

Merged
merged 16 commits into from Jun 8, 2018
Merged

ocamlPackages: use opaline instead of opam-installer #41591

merged 16 commits into from Jun 8, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 6, 2018

Motivation for this change

The opam package which provides the opam-installer tool does not currently build on aarch64 and has too many dependencies.

The opaline tool provides similar functionality to opam-installer, without the drawbacks listed above.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: jbuilder

Partial log (click to expand)

moving /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/man to /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/share/man
moving /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/doc to /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20
shrinking /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/bin/jbuilder
gzipping man pages under /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/lib  /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20/bin
patching script interpreter paths in /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20
checking for references to /build in /nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20...
/nix/store/d83i6a79j7qk0b0r7a0mz2g29zzs4qn8-jbuilder-1.0+beta20

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: jbuilder

Partial log (click to expand)

moving /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/man to /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/share/man
moving /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/doc to /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20
shrinking /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/bin/jbuilder
gzipping man pages under /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/lib  /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20/bin
patching script interpreter paths in /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20
checking for references to /build in /nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20...
/nix/store/lc29f7aq7zs1i93xbhxjpvr5ani7gywp-jbuilder-1.0+beta20

@xeji xeji merged commit af5b858 into NixOS:master Jun 8, 2018
@vbgl vbgl deleted the opaline branch June 9, 2018 06:20
@vbgl vbgl mentioned this pull request Jun 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @GrahamcOfBorg @xeji