Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.http-link-header: disable tests #41593

Merged
merged 1 commit into from Jun 8, 2018
Merged

haskellPackages.http-link-header: disable tests #41593

merged 1 commit into from Jun 8, 2018

Conversation

erictapen
Copy link
Member

My patch at #41592 might be applicable to master as well.

Motivation for this change
Things done

Disabled tests on haskellPackages.http-link-header.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erictapen erictapen requested a review from peti as a code owner June 6, 2018 16:09
peti
peti requested changes Jun 6, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit hackage-packages.nix. That is a generated file. Overrides like this one belong into configuration-common.nix.

@erictapen
haskellPackages.http-link-header: disable tests
33ffa1f 
The test

  Network.HTTP.Link, writeLinkHeader → parseLinkHeader, roundtrips successfully

seems to flap, as I cannot reproduce the failure locally, but it occured on
Hydra [0]. Also upstream is aware of the problem [1].

[0] https://hydra.nixos.org/build/75041105
[1] sjshuck/http-link-header#7
@erictapen erictapen force-pushed the haskellPackages-http-link-header-disable-tests branch from cf54502 to 33ffa1f Compare June 6, 2018 16:44
@erictapen
Copy link
Member Author

Thanks. Updated here as well.

@peti peti merged commit 6bde64f into NixOS:master Jun 8, 2018
@erictapen erictapen deleted the haskellPackages-http-link-header-disable-tests branch June 8, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @peti @GrahamcOfBorg