Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nixos-18.03] haskellPackages.http-link-header: disable tests #41592

Conversation

erictapen
Copy link
Member

The test

Network.HTTP.Link, writeLinkHeader → parseLinkHeader, roundtrips successfully

seems to flap, as I cannot reproduce the failure locally, but it occured on
Hydra [0]. Also upstream is aware of the problem [1].

[0] https://hydra.nixos.org/build/75041105
[1] sjshuck/http-link-header#7

Motivation for this change

As the Hydra build failed, I needed to build haskellPackages.github-backup by myself, as it depends on the package in question. As the local build was successful without this patch, it seems to me like

  • the test suite of http-link-header is flapping
  • the local build could be avoided by disabling the test suite
Things done

Disabled tests on haskellPackages.http-link-header.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit hackage-packages.nix. That is a generated file. Overrides like this one belong into configuration-common.nix.

The test

  Network.HTTP.Link, writeLinkHeader → parseLinkHeader, roundtrips successfully

seems to flap, as I cannot reproduce the failure locally, but it occured on
Hydra [0]. Also upstream is aware of the problem [1].

[0] https://hydra.nixos.org/build/75041105
[1] sjshuck/http-link-header#7
@erictapen erictapen force-pushed the nixos-1803-http-link-header-disable-tests branch from 3529462 to b374896 Compare June 6, 2018 16:40
@erictapen
Copy link
Member Author

Thanks for pointing this out. Updated the branch.

@peti peti merged commit 1d66f56 into NixOS:staging-18.03 Jun 7, 2018
@erictapen erictapen deleted the nixos-1803-http-link-header-disable-tests branch June 7, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants