Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.functory: 0.5 -> 0.6 #41596

Merged
merged 1 commit into from Jun 6, 2018
Merged

ocamlPackages.functory: 0.5 -> 0.6 #41596

merged 1 commit into from Jun 6, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 6, 2018

Motivation for this change

Support for OCaml ≥ 4.06

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 6, 2018

@GrahamcOfBorg build ocamlPackages.functory cubicle

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.functory, cubicle

Partial log (click to expand)

Compiling common/bitv.cmx
File "common/bitv.ml", line 538, characters 29-74:
Warning 3: deprecated: String.set
Use Bytes.set instead.
File "common/bitv.ml", line 538, characters 29-30:
Error: This expression has type string but an expression was expected of type
         bytes
make: *** [Makefile:172: common/bitv.cmx] Error 2
builder for '/nix/store/9bjpalzjarlybacx6p7x3kd74mfxliz9-cubicle-1.1.1.drv' failed with exit code 2
error: build of '/nix/store/9bjpalzjarlybacx6p7x3kd74mfxliz9-cubicle-1.1.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.functory, cubicle

Partial log (click to expand)

Installation completed in /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1/bin. You may want to copy (doc/)emacs/cubicle-mode.el in your emacs.d if you use Emacs.
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1
shrinking /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1/bin/cubicle
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1/bin
patching script interpreter paths in /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1
checking for references to /build in /nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1...
/nix/store/kpymp9n03w2igcbgzhg6k6j4m152pj63-ocaml4.05.0-functory-0.6
/nix/store/diyxv36vrxy1dzgqzhjr4xrg96binzhz-cubicle-1.1.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages.functory, cubicle

Partial log (click to expand)

install flags: SHELL=/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash install
mkdir -p /nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1/bin
cp -f cubicle.opt /nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1/bin/cubicle
Installation completed in /nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1/bin. You may want to copy (doc/)emacs/cubicle-mode.el in your emacs.d if you use Emacs.
post-installation fixup
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1/bin
patching script interpreter paths in /nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1
/nix/store/ai6hvwc35d9lraqrwkdp9p33z7zm7938-ocaml4.05.0-functory-0.6
/nix/store/wlzw3cda78palfwpwvgmhqikyknpr4af-cubicle-1.1.1

@xeji
Copy link
Contributor

xeji commented Jun 6, 2018

aarch64: functory builds, cubicle fails.

@xeji xeji merged commit 6c42674 into NixOS:master Jun 6, 2018
@vbgl vbgl deleted the ocaml-functory-0.6 branch June 7, 2018 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @xeji @GrahamcOfBorg