Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: remove libstdc++5 dependency #41590

Merged
merged 1 commit into from Jun 6, 2018
Merged

skypeforlinux: remove libstdc++5 dependency #41590

merged 1 commit into from Jun 6, 2018

Conversation

tkerber
Copy link
Member

@tkerber tkerber commented Jun 6, 2018

Motivation for this change

skypeforlinux does not require libstdc++5 to function, and the latter is currently broken (See #41585).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji merged commit 979a835 into NixOS:master Jun 6, 2018
rycee pushed a commit that referenced this pull request Jul 23, 2018
@tkerber @rycee
skypeforlinux: remove libstdc++5 dependency (#41590)
cb6b846 
(cherry picked from commit 979a835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tkerber @GrahamcOfBorg @xeji