Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NKF still uses Charset transcoding rather than jcodings #3666

Closed
headius opened this issue Feb 14, 2016 · 1 comment
Closed

NKF still uses Charset transcoding rather than jcodings #3666

headius opened this issue Feb 14, 2016 · 1 comment
Labels
encoding JRuby 9000 stdlib
Milestone
JRuby 9.1.0.0

Comments

@headius
Copy link
Member

headius commented Feb 14, 2016

There are four failures in test_kconv.rb that appear to be caused, at least in part, by our NKF library still using Java's Charset to do transcoding rather than jcodings. Many of the encodings that jcodings supports are not available in Java.

We should try to fix up the remaining NKF issues by using jcodings to do transcoding like MRI.

Relates to #3261.
@headius
Copy link
Member Author

headius commented Mar 4, 2016

This is fixed in c6e43c0.

@headius headius closed this as completed Mar 4, 2016
@headius headius added this to the JRuby 9.1.0.0 milestone Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
encoding JRuby 9000 stdlib
Projects
None yet
Milestone
JRuby 9.1.0.0
Development

No branches or pull requests
1 participant
@headius