[Truffle] Avoid setting the store when unnecessary in Array#<<.

jruby · Feb 3, 2016 · cedd730 · cedd730
1 parent 832eff3
commit cedd730
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/truffle/src/main/java/org/jruby/truffle/core/array/ArrayAppendOneNode.java b/truffle/src/main/java/org/jruby/truffle/core/array/ArrayAppendOneNode.java
@@ -94,17 +94,15 @@ public void appendOneSameTypeGeneric(DynamicObject array, ArrayMirror storeMirro
         final int oldSize = Layouts.ARRAY.getSize(array);
         final int newSize = oldSize + 1;
 
-        final ArrayMirror newStoreMirror;
-
         if (extendProfile.profile(newSize > storeMirror.getLength())) {
-            newStoreMirror = storeMirror.copyArrayAndMirror(ArrayUtils.capacityForOneMore(storeMirror.getLength()));
+            final ArrayMirror newStoreMirror = storeMirror.copyArrayAndMirror(ArrayUtils.capacityForOneMore(storeMirror.getLength()));
+            newStoreMirror.set(oldSize, value);
+            Layouts.ARRAY.setStore(array, newStoreMirror.getArray());
+            Layouts.ARRAY.setSize(array, newSize);
         } else {
-            newStoreMirror = storeMirror;
+            storeMirror.set(oldSize, value);
+            Layouts.ARRAY.setSize(array, newSize);
         }
-
-        newStoreMirror.set(oldSize, value);
-        Layouts.ARRAY.setStore(array, newStoreMirror.getArray());
-        Layouts.ARRAY.setSize(array, newSize);
     }
 
     // Append forcing a generalization from int[] to long[]