-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jruby-complete osgi bundle does not export com.jcraft.jzlib.* #3681
Comments
the library which fails me with jruby-complete is this https://github.com/mkristian/nexus2-internal/blob/master/plugins/rubygem/nexus-ruby-tools/src/main/java/org/sonatype/nexus/ruby/layout/HostedPOSTLayout.java#L35 the fix is trivial in the case - just use GZIPInputStream from java.util.zip - but the general problem remains |
It would be fine with me to make a jruby-zlib gem if it helps isolate dependencies. The zlib library does not change particularly often. I don't think any of us are excited about another external repo, but this fits the pattern for the other libs (and I guess I haven't even given readline any thought for a while). However...I think it might not be good to try to do this a few days before release :-) I'm punting to 9.1.1. Any concerns @enebo? |
there is another osgi one: #3821 |
Do we have any progress on this, @mkristian? |
@mkristian We could also shade this into a JRuby package, right? We never expose the jzlib API via the JRuby API. |
Removing from release. @mkristian We can do this whenever you decide what's best. |
sorry not responding - did not see it. in both cases we might brake projects which depends on it (like nexus-ruby-tools of mine :) |
I don't know if we have made any more progress on this. @mkristian Can you confirm this is still a problem? |
the problem is that when you have library which compiles against jruby it might use com.jcraft.jzlib.GZIPInputStream but running this library as osgi bundle along side jruby-complete bundle, it fails when using com.jcraft.jzlib.* classes.
exporting the com.jcraft.jzlib.* for jruby-complete is not the right way as it may conflict with actual jcraft library.
with jruby-9k we moved most extension using external libraries to gems which embed those external libraries: psych, readline
doing this for the core/src/main/java/org/jruby/ext/zlib/ extension would remove the jcraft dependency.
but this means another github repo for jruby-zlib
@enebo @headius would that be OK to go for a jruby-zlib gem like jruby-readline ?
The text was updated successfully, but these errors were encountered: