ObjectSpace._id2ref raises for invalid ID values

Fixes #3504
rubinius · Feb 12, 2016 · 89cf641 · 89cf641
1 parent 8b7d91b
commit 89cf641
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/object_space.rb b/core/object_space.rb
@@ -6,11 +6,12 @@ def self.find_object(query, callable)
 
   def self._id2ref(id)
     ary = []
+
     if find_object([:object_id, Integer(id)], ary) > 0
       return ary.first
     end
 
-    return nil
+    raise RangeError, "#{id} is not a valid ID value"
   end
 
   def self.find_references(obj)

diff --git a/spec/ruby/core/objectspace/_id2ref_spec.rb b/spec/ruby/core/objectspace/_id2ref_spec.rb
@@ -18,4 +18,8 @@
     r = ObjectSpace._id2ref(s.object_id)
     r.should == s
   end
+
+  it 'raises RangeError when an object could not be found' do
+    proc { ObjectSpace._id2ref(1 << 60) }.should raise_error(RangeError)
+  end
 end