Clean up define method #3617
Merged
Clean up define method #3617
+86
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…define_method which is needed by Method and UnboundMethod
… delegate responsibility further to executables
…lity of Method,UnboundMethod #for_define_method, add 3rd arg callabale_proc to Method,UnboundMethod #for_define_method
…nvironment::AsMethod
… @ruby_method is set
|
Regarding to d59ca90 My reasoning behind this was this code part in the previous impl: We used the block scope after duping the proc but also we duped the block first. |
|
@tak1n this is a great first step, thanks for working on it. We'll continue to evolve some of these APIs to be even more simple. If you feel confident with this now, go ahead and merge, please! 👍 |
… old impl to ensure the same behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I tried to ship most of the logic towards executables and use
Method#for_define_methodandUnbindMethod#for_define_methodas thin wrapper aroundExecutable#for_define_method.The result can be seen here: 7cd4315
When the need to support Proc again came up it was clear that shipping most of the stuff into executables was not quite doable, or at least I was not able to do it properly.
Therefore I moved it up into
MethodandUnboundMethodwhere again we have nested conditionals (but at least no more nested conditionals in a big fat case statement)As for
BlockEnvironment::AsMethod#scopeI'm not sure if this should return nil or the scope of@block_env. In the previous implementationdefine_methodfor aBlockEnvironment::AsMethodexecutable used nil as scope. Also when changing it to@block_env.scopeall ci specs are still passing so probably this means there are missing specs for that.