-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures in JRuby 9.0.5.0 on Sinatra build #3633
Comments
first error is due: the rest seems that |
💚 build at sinatra/sinatra#1091 ... expect this to be a local mess at /Users/zscott |
@kares Sorry, it was the wrong stack trace, here it is:
From travis: https://travis-ci.org/sinatra/sinatra/jobs/106516310 |
🃏 mustermann striped down reproduction .rb piece :
|
@zzak That trace looks like a bug in JIT, but I'm not sure how it would happen. |
Ok, this shouldn't be bad. The method in question is here: def initialize(string, **options)
super
regexp = compile(**options)
@peek_regexp = /\A(#{regexp})/
@regexp = /\A#{regexp}\Z/
end And it's the |
Hmm. I'm still having no luck reproducing this on my local system with either 9.0.5.0 or master on Java 8. |
If someone else can reproduce this consistently with @kares' script, please run it with -Xcompile.dump and gist the output somewhere. |
@headius reproducing consistently (tried recent master) ... here's my setup https://gist.github.com/kares/410a35e3ba69bdf2a770 you'll find a require 'mustermann'
require 'mustermann/sinatra'
counter = 0
1000.times do
counter += 1
Mustermann::AST::Pattern.new("/#{counter}")
end ... previously a failed to narrow this down further except as you say that its kwrest related |
Nice find! |
Wooooooo!! 🙌 |
Hello!
We're seeing the following failures in Sinatra on latest JRuby, I can reproduce with 9.0.5.0 on my machine:
Here's the build: https://travis-ci.org/sinatra/sinatra/builds/105858800
/cc @rkh
The text was updated successfully, but these errors were encountered: