Skip to content

Commit

Permalink
remove deprecated format_regex attribute from Mojolicious::Routes::Pa…
Browse files Browse the repository at this point in the history
…ttern
  • Loading branch information
kraih committed Feb 2, 2016
1 parent d19e4fd commit c6f119f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
1 change: 1 addition & 0 deletions Changes
@@ -1,5 +1,6 @@

6.44 2016-02-02
- Removed deprecated format_regex attribute from Mojolicious::Routes::Pattern.
- Improved Mojo::JSON performance slightly.

6.43 2016-02-01
Expand Down
8 changes: 0 additions & 8 deletions lib/Mojolicious/Routes/Pattern.pm
@@ -1,8 +1,6 @@
package Mojolicious::Routes::Pattern;
use Mojo::Base -base;

use Mojo::Util 'deprecated';

has [qw(constraints defaults)] => sub { {} };
has placeholder_start => ':';
has [qw(placeholders tree)] => sub { [] };
Expand All @@ -12,12 +10,6 @@ has [qw(regex unparsed)];
has relaxed_start => '#';
has wildcard_start => '*';

# DEPRECATED in Clinking Beer Mugs!
sub format_regex {
deprecated 'Mojolicious::Routes::Pattern::format_regex is DEPRECATED';
return @_ > 1 ? $_[0] : undef;
}

sub match {
my ($self, $path, $detect) = @_;
my $captures = $self->match_partial(\$path, $detect);
Expand Down
7 changes: 2 additions & 5 deletions t/pod_coverage.t
Expand Up @@ -7,11 +7,8 @@ plan skip_all => 'set TEST_POD to enable this test (developer only!)'
plan skip_all => 'Test::Pod::Coverage 1.04+ required for this test!'
unless eval 'use Test::Pod::Coverage 1.04; 1';

my %RULES = (
'Mojolicious::Routes::Pattern' => {also_private => ['format_regex']},
'Mojo::Transaction::WebSocket' =>
{also_private => [qw(build_frame parse_frame)]},
);
my %RULES = ('Mojo::Transaction::WebSocket' =>
{also_private => [qw(build_frame parse_frame)]},);
pod_coverage_ok($_, $RULES{$_} || {}) for all_modules();

done_testing();

0 comments on commit c6f119f

Please sign in to comment.