Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codedb ffi io #3619

Merged
merged 233 commits into from Jul 11, 2016
Merged

Codedb ffi io #3619

merged 233 commits into from Jul 11, 2016

Conversation

chuckremes
Copy link
Member

Looks like we have a lot of design-in-process inventory (DIP) on this long-lived branch. Need to get this merged soon. :)

@chuckremes
add basic support for additional IO functions
cf961ab
@chuckremes
add back dup2 function definition
cd2fadb
@chuckremes
add convenience methods for errno handling
bbd1acf
@chuckremes
add O_CLOEXEC to list for File IO
5284dc5
@chuckremes
add a few more functions like ftruncate to the list
c550d51
@chuckremes
hack away and rejigger things to get IO booting using mostly FFI calls
8412c75
@chuckremes
make some fixes to pass more specs
d762c3e
@chuckremes
passes most read specs
c5f692d
@chuckremes
add spec for negative IO#pos when 'unget'ing at start of stream
9e9a6ca
@chuckremes
more fixes to pass ungetc/ungetbyte/pos/read specs; all pass
94704d8
@chuckremes
fix #getc to handle encodings properly; passes chars_spec
4fb420e
@chuckremes
fix read_to_separator to handle skipping properly
84dcf88
@chuckremes
specs for requesting a negative-sized pointer which causes SEGV
6a0742e
@chuckremes
return NULL for a MemoryPointer.new with a negative size
c936f67
@chuckremes
add basic support for additional IO functions
5f35e00
@chuckremes
add back dup2 function definition
7e9db0c
@chuckremes
add convenience methods for errno handling
b20d2df
@chuckremes
add O_CLOEXEC to list for File IO
200e892
@chuckremes
add a few more functions like ftruncate to the list
d2a2e24
@chuckremes
hack away and rejigger things to get IO booting using mostly FFI calls
3eb0672
@chuckremes
make some fixes to pass more specs
d545ebb
@chuckremes
passes most read specs
706385f
@chuckremes
add spec for negative IO#pos when 'unget'ing at start of stream
425823c
@chuckremes
more fixes to pass ungetc/ungetbyte/pos/read specs; all pass
3c5b581
@chuckremes
fix #getc to handle encodings properly; passes chars_spec
6af8087
@chuckremes
fix read_to_separator to handle skipping properly
77b0f42
@chuckremes
specs for requesting a negative-sized pointer which causes SEGV
9e3a630
@chuckremes
return NULL for a MemoryPointer.new with a negative size
4cffe04
@chuckremes
raise IOError on malloc failure; force returned strings to binary
abebac0
@chuckremes
force strings to binary for handling #gets with separators and limits…
f1893d2 
…; remove debug prints
brixen and others added 24 commits June 6, 2016 15:08
@brixen
Merge remote-tracking branch 'origin' into codedb-ffi-io
08c6a86
@brixen
Fixed finalizer spec to clean up temporary.
174a3ab
@brixen
Merge remote-tracking branch 'origin' into codedb-ffi-io
e200552
@brixen
Merge remote-tracking branch 'origin' into codedb-ffi-io
cb6f950
@chuckremes
Merge branch 'master' into codedb-ffi-io
3cbca7e
@brixen
Merge remote-tracking branch 'origin' into codedb-ffi-io
9a0726c
@chuckremes
ignore NotImplementedError for #fadvise on platforms that do not supp…
71f8600 
…ort that call
@chuckremes
bump ruby compatibility to 2.3.0
204fae4
@chuckremes
rename spec file so ci run matches 2.3.0 ruby compat
b529270
@chuckremes
verify that infinitely looping subprocesses can be force closed
0a51083
@chuckremes
remove special case EPIPE error handling so all write errors bubble up
90d1951
@chuckremes
clarify intent of spec
f11426b
@chuckremes
make sure we test for new transcoding options
679a247
@chuckremes
prepare to handle passing more encoding options in IO.open/File.open
473c787
@chuckremes
stub in an attempt at hooking up newline transcoders
39d255f
@chuckremes
stub in attempt at accessing transcoders
6455dc7
@chuckremes
fix regex so it matches newline transcoders
f19819b
@chuckremes
Merge branch 'codedb-ffi-io' of https://github.com/rubinius/rubinius …
f2f34d5 
…into codedb-ffi-io
@chuckremes
Revert "stub in attempt at accessing transcoders"
72ece66 
This reverts commit 6455dc7.
@chuckremes
Revert "stub in an attempt at hooking up newline transcoders"
4dd5076 
This reverts commit 39d255f.
@chuckremes
Revert "make sure we test for new transcoding options"
76959b7 
This reverts commit 679a247.
@chuckremes
fix encoding_options handling to pass specs
11458eb
@brixen
Merge remote-tracking branch 'origin' into codedb-ffi-io
f7665ae
@brixen
Guard calling fclose() on NULL rio-f.
88f794e
@brixen brixen merged commit a8f23c1 into master Jul 11, 2016
@brixen
Copy link
Member

brixen commented Jul 11, 2016

@chuckremes thank you for the tremendous amount of work here and for the commitment to seeing this through despite the difficulties and the extended period of time it took to work on all the issues.

Any remaining clean up or improvement can happen on master and be sure to take advantage of the ability to tag a release at any time.

@brixen brixen deleted the codedb-ffi-io branch July 11, 2016 23:36
@tmornini
Copy link
Contributor

WOOHOO! Congrats @chuckremes and @brixen , this is a labor of love!

@brixen
Copy link
Member

brixen commented Jul 14, 2016

Thanks @tmornini!

@chuckremes
Copy link
Member Author

It truly was a labor of love. :)

Now to make it better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chuckremes @tmornini @brixen