Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] instance_eval should allow three arguments #3677

Closed
bjfish opened this issue Feb 17, 2016 · 2 comments
Closed

[Truffle] instance_eval should allow three arguments #3677

bjfish opened this issue Feb 17, 2016 · 2 comments
Milestone
Non-Release

Comments

@bjfish
Copy link
Contributor

bjfish commented Feb 17, 2016

Example code

class Test
end

code = <<-eos
  def blah?
    true
  end
eos

Test.instance_eval(code, "blah.rb", 30)
puts Test.blah?

Expected
true

Actual

/Users/brandonfish/Documents/jruby-patches/ineval.rb:11:in `instance_eval': wrong number of arguments (3 for 0) (ArgumentError)
    from /Users/brandonfish/Documents/jruby-patches/ineval.rb:11:in `<main>'

Used in bundler. I think the second and third arguments could be ignored for usage in error reporting for now if too difficult to implement.
@bjfish bjfish added the truffle label Feb 17, 2016
@nirvdrum nirvdrum changed the title [Truflle] instance_eval should allow three arguments [Truffle] instance_eval should allow three arguments Feb 17, 2016
@chrisseaton chrisseaton added this to the truffle-dev milestone Feb 17, 2016
@bjfish
Copy link
Contributor Author

bjfish commented Apr 19, 2016

This appears to be fixed. Maybe at this commit: 72f116a

@bjfish bjfish closed this as completed Apr 19, 2016
@pitr-ch
Copy link
Member

pitr-ch commented Apr 20, 2016

yeah, sorry I missed the issue.

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

No branches or pull requests
4 participants
@enebo @bjfish @pitr-ch @chrisseaton