Skip to content

Commit

Permalink
Revert "Add workaround for analyzer core bug (#206)."
Browse files Browse the repository at this point in the history
This reverts commit e94a923.
sbourdeauducq committed Feb 15, 2016
1 parent e94a923 commit 649f3b9
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions artiq/runtime/rtio.c
Original file line number Diff line number Diff line change
@@ -50,37 +50,25 @@ void rtio_log_va(long long int timestamp, const char *fmt, va_list args)
rtio_chan_sel_write(CONFIG_RTIO_LOG_CHANNEL);
rtio_o_timestamp_write(timestamp);

int i = 0, j = 0;
int i = 0;
unsigned int word = 0;
while(1) {
word <<= 8;
word |= *buf & 0xff;
if(*buf == 0) {
j++;
rtio_o_data_write(word);
rtio_o_we_write(1);
break;
}
buf++;
i++;
if(i == 4) {
j++;
rtio_o_data_write(word);
rtio_o_we_write(1);
word = 0;
i = 0;
}
}

if(j % 2 == 1) {
// https://github.com/m-labs/artiq/issues/206#issuecomment-167347507
// Note: due to a bug in the analyzer core, for now make sure that all runs
// produce an even number of analyzer messages. As far as the log is concerned,
// an analyzer message contains 4 characters of payload, the terminal 0 counts
// as one, and the payload of one log entry is padded to a message boundary.
rtio_o_data_write(0);
rtio_o_we_write(1);
}
}

void rtio_log(long long int timestamp, const char *fmt, ...)

0 comments on commit 649f3b9

Please sign in to comment.