@thelinuxkid Master should be green now if you want to test

looks like theres an actual issue on the osx travis tests, it cant find fusermount

It looks like it's missing gx https://travis-ci.org/thelinuxkid/go-ipfs/jobs/109452862#L1339, https://travis-ci.org/thelinuxkid/go-ipfs/jobs/109452865#L3651. Since gxis a a package tool I don't know how it interfaces with Godeps.

You would have to rebase is on top of master again and see how .travis.yml works now.

Hmm. I have already rebased and that line is there: https://github.com/thelinuxkid/go-ipfs/blob/master/.travis.yml#L23.

I see. I think the package changed: https://travis-ci.org/thelinuxkid/go-ipfs/jobs/109452862#L182.

@thelinuxkid i see whats going wrong here, mind if i push a commit?

Sure. I found a couple of things though. I had to do a go clean in order for both gx and gx-go to work correctly. Also, it looks like gx --verbose install --global is not taking into account that GOPATH can have several paths.

I already made the changes to the fuse module though.I can push those.

ooooh, the multiple components thing is definitely not considered by gx... I'll fix that

I am going to leave the go clean out. It breaks everything if the packages don't already exist. @whyrusleeping let me know when the GOPATH change has been made.

@whyrusleeping I am seeing the fusermount error on osx now https://travis-ci.org/thelinuxkid/go-ipfs/jobs/109495802#L3695. It's the only thing failing at the moment. I will look further into it.

@thelinuxkid yeah, i pushed the multiple GOPATH fix last night

@whyrusleeping Cool. Just tested it. Works for me. Also rebased. Let me know how this change looks thelinuxkid@85b9ef3. I couldn't get the upgrade to work without the go clean.

re: osx fusermount https://github.com/osxfuse/osxfuse/wiki/FAQ#48-how-should-i-unmount-my-fuse-for-os-x-file-system-i-cannot-find-the-fusermount-program-anywhere

@thelinuxkid what was the failure case fixed by adding that go clean there?

@whyrusleeping make toolkit_upgrade didn't fix things until I ran go clean.

@whyrusleeping Tests passing. Please merge.

There was a stall error (unrelated to this). But it the test passed at first retry: https://travis-ci.org/ipfs/go-ipfs/builds/113009295

@chriscool wanna take a look at this one?

pending chris' feedback, this LGTM

Both of the travis failures are fuse issues... We've spent a lot of time lately making sure our CI is green. I need to think about what we want to do here, i'd prefer not to merge in things that make our CI less green, but I also don't want to delay this code merging any longer.

Except the points about unmounting this LGTM!

Also is a fix for #2214 needed?

Maybe we could enable the fuse testing under travis CIs 'allowed failures' target for now: https://docs.travis-ci.com/user/customizing-the-build/#Rows-that-are-Allowed-to-Fail

@whyrusleeping what failures are you referring to?

@chriscool you can close #2214

@whyrusleeping OK. I was looking at my own travis tests which are passing. I see the context canceled error which shows up intermittently in the go tests. I had not seen it in a while. That might be an easy fix. I don't see an error for the sharness job that failed though.

@whyrusleeping @chriscool can the context canceled error be ignored in this instance?

func (r *Root) Close() error {
    for _, mr := range r.Roots {
        err := mr.root.Close()
        if err != nil && err != context.Canceled {
            return err
        }
    }
    return nil
}

Closing as inactive, reopen as necessary