Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include system library locations in Module.globalPaths #1390

Closed
kevinsawicki opened this issue Apr 8, 2015 · 1 comment
Closed

Don't include system library locations in Module.globalPaths #1390

kevinsawicki opened this issue Apr 8, 2015 · 1 comment
Labels
security 🔒

Comments

@kevinsawicki
Copy link
Contributor 

require('module').globalPaths

shows:

[
  "/Users/kevin/.node_modules",
  "/Users/kevin/.node_libraries",
  "/Applications/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/lib/node",
  "/Applications/Atom.app/Contents/Resources/atom.asar/renderer/api/lib",
  "/Applications/Atom.app/Contents/Resources/app",
  "/Applications/Atom.app/Contents/Resources/app.asar",
  "/Applications/Atom.app/Contents/Resources/atom.asar/common/api/lib",
  "/Applications/Atom.app/Contents/Resources/app/exports"
]

Seems like /Users/kevin/.node_modules and /Users/kevin/.node_libraries shouldn't be put on there since they could contain modules not shipped with the app and possibly compiled with the wrong v8 headers.

/cc @paulcbetts
@kevinsawicki kevinsawicki changed the title Don't include system library locations in globalPaths Don't include system library locations in Module.globalPaths Apr 8, 2015
This was referenced Apr 15, 2015
Closed
Closed
@zcbenz
Copy link
Contributor

zcbenz commented Apr 23, 2015

Fixed by #1448.

@zcbenz zcbenz closed this as completed Apr 23, 2015
@kevinsawicki kevinsawicki mentioned this issue Jul 21, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: remove system paths from search deepak1556/atom-shell
2 participants
@zcbenz @kevinsawicki