Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gramps426 #30200

Merged
merged 2 commits into from Oct 7, 2017
Merged

Update gramps426 #30200

merged 2 commits into from Oct 7, 2017

Conversation

joncojonathan
Copy link
Member

Motivation for this change

Gramps was at version 4.1.1 and had been for some time. This was quite out of date. Moving to 4.2.6 required enabling BSDDB3 which it was found was working with Python3, but the tests were not working (hence those checks disabled).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Motivation for change: GRAMPS was a long way out of date.

Additional information: BSDDB3 unmasked as this is supported by the current Python3 version (commited separately).
Motivation for change: Tests disabled as BSDDB3 works with Python3 but the tests do not.
@Mic92
Copy link
Member

Mic92 commented Oct 7, 2017

I also had to disable python3 for spambayes: 58b6d3f

@Mic92 Mic92 merged commit 8f8a7f3 into NixOS:master Oct 7, 2017
@joncojonathan joncojonathan deleted the update-gramps426 branch January 29, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants