Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom-beta: 1.21.0-beta0 -> 1.22.0-beta0 #30201

Merged
merged 1 commit into from Oct 7, 2017
Merged

atom-beta: 1.21.0-beta0 -> 1.22.0-beta0 #30201

merged 1 commit into from Oct 7, 2017

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Oct 7, 2017 •
edited

Motivation for this change

Update, fix derivation name to not collide with stable Atom.

Fix #30198

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@domenkozar @FRidh @TerkiKerel

@NeQuissimus NeQuissimus added 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 7, 2017
@domenkozar domenkozar merged commit 56ca2a5 into NixOS:master Oct 7, 2017
@NeQuissimus NeQuissimus deleted the atom_beta_1_22_0 branch October 7, 2017 19:42
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"atom" package changed as "atom-beta" automatically
3 participants
@NeQuissimus @domenkozar @samueldr