Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnstracer: init at 1.9 #30203

Merged
merged 2 commits into from Oct 7, 2017
Merged

dnstracer: init at 1.9 #30203

merged 2 commits into from Oct 7, 2017

Conversation

andir
Copy link
Member

@andir andir commented Oct 7, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from edolstra as a code owner October 7, 2017 20:33
@Mic92
Copy link
Member

Mic92 commented Oct 7, 2017

Thanks!

@Mic92 Mic92 merged commit a088376 into NixOS:master Oct 7, 2017
@andir andir deleted the add-dnstracer branch October 8, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @Mic92