Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-generate-config: lessen priority for cpuFreqGovernor #30221

Merged
merged 1 commit into from Oct 20, 2017
Merged

nixos-generate-config: lessen priority for cpuFreqGovernor #30221

merged 1 commit into from Oct 20, 2017

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Oct 8, 2017

In particular, it conflicts with services.tlp.enable option.

There exists workaround:

  powerManagement.cpuFreqGovernor = lib.mkForce null;
  services.tlp.enable = true;

But should it?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@danbst
nixos-generate-config: lessen priority for cpuFreqGovernor
a993f74 
In particular, it conflicts with `services.tlp.enable` option.

There exists workaround:
```
  powerManagement.cpuFreqGovernor = lib.mkForce null;
  services.tlp.enable = true;
```
But should it?
@joachifm joachifm mentioned this pull request Oct 12, 2017
Closed
8 tasks
@joachifm joachifm merged commit dab7ecc into NixOS:master Oct 20, 2017
@danbst danbst deleted the patch-14 branch October 20, 2017 22:21
@ghost
Copy link

ghost commented Dec 24, 2017

And now there is an error

error: The unique option `powerManagement.cpuFreqGovernor' is defined multiple times, in `/etc/nixos/hardware-configuration.nix' and `/home/gnidorah/tmp/nixpkgs/nixos/modules/config/power-management.nix'.

If I use hardware-configuration.nix generated by installer and no TLP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@lheckemann lheckemann lheckemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danbst @bjornfor @lheckemann @joachifm