ghcjs/ghcjsHEAD: Use separate patch files to fix build of ghcjs #30214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure seems unrelated. |
|
Is it possible to download that patch from somewhere instead of checking it into the Nixpkgs repository? |
|
We could download the |
cocreature
added a commit
to cocreature/nixpkgs
that referenced
this pull request
Oct 21, 2017
This has been fixed in NixOS#30214
8 tasks
domenkozar
pushed a commit
that referenced
this pull request
Oct 21, 2017
This has been fixed in #30214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In #29696 I removed the patch for building
ghcjsusing cabal-install 2.0 since it had been merged upstream intoGHCJS 8.0(ghcjsHEADinnixpkgs). However, I’ve missed that this is also used forghcjswhich still needs this patch and is currently broken due to this change (sorry about this).Things done
Separate the patch files for
ghcjsHEADandghcjsand include thecabal-install 2.0patch forghcjs.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)