Indicate burn type being used by flight planner #1610
Closed
+19
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burn type being used could have gone into Compute[Engine|RCS]Characteristics() and/or UseTheForceLuke(), but that wouldn't work later if/when the ability for the user to select specific engines for a burn is added, since ComputeEngineCharacteristics would be used when "normal" engines are used for the burn, regardless of whether the engines used for the burn were selected manually by the user or by the "Active Engines" button.
|
As discussed on IRC, this information is not persisted (the principia.serialization.Manoeuvre message would have to include it, as well as the interchange principia.journal.serialization.Burn). Closing for now; @aw1621107, feel free to reopen later if you want to do the persistence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Burn type being used could have gone into
Compute[Engine|RCS]Characteristics() and/or UseTheForceLuke(), but that
wouldn't work later if/when the ability for the user to select specific
engines for a burn is added, since ComputeEngineCharacteristics would be
used when "normal" engines are used for the burn, regardless of whether
the engines used for the burn were selected manually by the user or by
the "Active Engines" button.