New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc2-headless: init at 3.17 #30481
sc2-headless: init at 3.17 #30481
Conversation
else assert licenseAccepted; | ||
stdenv.mkDerivation rec { | ||
version = "3.17"; | ||
name = "SC2.${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like name = "sc2-headless-${version}";
better.
unzip -P 'iagreetotheeula' $curSrc | ||
''; | ||
|
||
buildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make that a one liner
]; | ||
|
||
installPhase = '' | ||
shopt -s dotglob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about cp -r . "$out"
?
|
||
preFixup = '' | ||
find $out -type f -print0 | while IFS=''' read -d ''' -r file; do | ||
isELF "$file" || continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
unzip -P 'iagreetotheeula' $curSrc | ||
''; | ||
|
||
buildInputs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be nativeBuildInputs
This packages up the Starcraft II headless Linux client provided by Blizzard for machine learning research.
, licenseAccepted ? false | ||
}: | ||
|
||
if !licenseAccepted then throw '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This packages up the Starcraft II headless Linux client provided by
Blizzard for machine learning research.
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)