Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependencies for Fedora #2671

Closed
wants to merge 280 commits into from

Conversation

shmacoshmuesday
Copy link

No description provided.

@moneromooo-monero
Copy link
Collaborator

You have some kind of merge commit in there. Please rebase so there's only your patch.

README.md Outdated

* Void Linux:

xbps-install -S monero
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove Void Linux instructions ?

README.md Outdated
@@ -418,7 +414,7 @@ See [README.i18n.md](README.i18n.md).

## Using Tor

While Monero isn't made to integrate with Tor, it can be used wrapped with torsocks, if you add --p2p-bind-ip 127.0.0.1 to the monerod command line. You also want to set DNS requests to go over TCP, so they'll be routed through Tor, by setting DNS_PUBLIC=tcp or use a particular DNS server with DNS_PUBLIC=tcp://a.b.c.d (default is 8.8.4.4, which is Google DNS). You may also disable IGD (UPnP port forwarding negotiation), which is pointless with Tor. To allow local connections from the wallet, you might have to add TORSOCKS_ALLOW_INBOUND=1, some OSes need it and some don't. Example:
While Monero isn't made to integrate with Tor, it can be used wrapped with torsocks, if you add --p2p-bind-ip 127.0.0.1 to the monerod command line. You also want to set DNS requests to go over TCP, so they'll be routed through Tor, by setting DNS_PUBLIC=tcp. You may also disable IGD (UPnP port forwarding negotiation), which is pointless with Tor. To allow local connections from the wallet, you might have to add TORSOCKS_ALLOW_INBOUND=1, some OSes need it and some don't. Example:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have made my changes on a previous version of this doc because I only added Fedora deps. Sorry for the noob mistakes. Will re-sync and re-submit later today.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, you can just rebase your patch on top of the latest master, assuming you used a branch. Even if not, git pull --rebase will do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip....it's taking me a bit but I'm learning everything I can along the way...will resubmit soon.

@radfish
Copy link
Contributor

radfish commented Oct 22, 2017

no need to close. you can push anything into same branch by overwriting with 'push -f'.

moneromooo-monero and others added 20 commits October 22, 2017 19:45
When loading an older wallet cache, they wouldn't be initialized,
leading them to have random(ish) values, and so assigned to some
random subaddress.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
… crash in monerod
Issue: monero-project#2575

Build instructions for OpenBSD 6.2:
* boost (built with clang)
* cppzmq

Fixed a issue, where cmake was not able to find and link against libressl in unbound.

restored OpenBSD 5.8 build instructions
It is safe in those cases, though might return slightly out of date
information if another thread is busy modifying the blockchain,
but it avoids potentially lengthy delays just to get things like
the current blockchain height.
Enable with perf:DEBUG
ca87cbd wallet2: fix subaddress fields serialization (moneromooo-monero)
4dd05a2 subaddress: change prefix so that it starts with 8 (kenshi84)
969b5a2 net_helper: fix massive slowdown after SSL support (moneromooo-monero)
310b790 make connection_id a string in RPC (moneromooo-monero)
f9fad18 blockchain_db: sanity check on tx/hash vector sizes (flozilla)
7256d9a Fix versioning (vdo)
e459d46 Update snap version to 0.11.1 (vdo)
d875a9f wallet2: detect multiple outputs from a tx to different subaddresses (moneromooo-monero)
631b35e CONTRIBUTING.md: mention git add -p as a way to avoid spurious changes (moneromooo-monero)
c0ae52c simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)
36b41ab added missing link for OpenBSD build instructions (ston1th)
b0426d4 Fixes monero-project#759 Add sanity check on restore height (Cifrado)
23b6f68 RPC: allow binding of restricted port in addition to core port (Tim L)
26ce640 Update README.md with info about release timelines (Gingeropolous)
8198f03 Add mdb_drop tool (Howard Chu)
c256a24 Android dockerfile: add zmq dependency (MoroccanMalinois)
@shmacoshmuesday
Copy link
Author

Sorry it closed when I deleted a branch or something. Learning a bit more before I re-submit.

@shmacoshmuesday
Copy link
Author

shmacoshmuesday commented Dec 3, 2017

Sorry I didn't mean to close it again, it closed when I rebased local and then pushed changes up to my github fork. I don't see a way to re-open it

@shmacoshmuesday
Copy link
Author

I see now, I need to push my change up again and then reopen the pull request - doing that now. Sorry for the noob mistakes.

@shmacoshmuesday
Copy link
Author

I think I may have it right this time. Thanks for your patience

@moneromooo-monero
Copy link
Collaborator

what the hell is happening here ? :D You should have one commit. There are so many here github wheezes and stops counting at 250. Try:

git rebase master

(when you're on your branch)

@shmacoshmuesday
Copy link
Author

lol dangit. I think I know what happened but it seems the end result is I need to practice some before attempting to submit changes here. The only change I made was to README.md but this is trying to push the updates that I fetched from your master, which are already there. Github does what it does well I know that, I just need some practice. Unfortunately, as indicated by the time between my attempts, my time is split between many things. I'll keep trying and hope to mark this item off the list asap.

@shmacoshmuesday
Copy link
Author

didn't mean to close

@moneromooo-monero
Copy link
Collaborator

If you can't work it out, you can redo it:

git checkout master
git pull
git branch new
git checkout new
git cherry-pick XXXX

and repace XXXX with the commit you intended to push. That gives you a clean branch with your changes as one commit.

@hegjon
Copy link
Contributor

hegjon commented Dec 15, 2017

Thanks for your list.

I would use lower case for gcc and openssl-devel:

$ rpm -q gcc openssl-devel
gcc-7.2.1-2.fc26.x86_64
openssl-devel-1.1.0g-1.fc26.x86_64
$ rpm -q GCC OpenSSL-devel
package GCC is not installed
package OpenSSL-devel is not installed

@moneromooo-monero
Copy link
Collaborator

+invalid

@shmacoshmuesday
Copy link
Author

Thank you hegjon and sorry for taking so long moneromoo, and thank you for your suggestions. You all are awesome. I'll keep trying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet